Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/211705
Change subject: Add missing newlines between "namespace" and "use" blocks ...................................................................... Add missing newlines between "namespace" and "use" blocks This fixes a single style guide issue accross the whole Wikibase.git code base: there must be a blank line between "namespace" and "use" (according to phpmd) and there should be a blank line before "namespace". This is split from If24d3d1 to make it easier to review. Change-Id: Icf93d0219f73a5901b7e9eebd4bc3ce60a7d3d64 --- M client/tests/phpunit/includes/Usage/PageEntityUsagesTest.php M client/tests/phpunit/includes/Usage/UsageAspectTransformerTest.php M lib/includes/Reporting/NullMessageReporter.php M lib/includes/formatters/DispatchingValueFormatter.php M lib/includes/formatters/OutputFormatSnakFormatterFactory.php M lib/includes/formatters/OutputFormatValueFormatterFactory.php M lib/includes/modules/RepoAccessModule.php M lib/tests/phpunit/Validators/MembershipValidatorTest.php M lib/tests/phpunit/Validators/NotEntityIdValidatorTest.php M lib/tests/phpunit/Validators/NumberRangeValidatorTest.php M lib/tests/phpunit/formatters/UnDeserializableValueFormatterTest.php M repo/includes/rdf/DateTimeValueCleaner.php M repo/includes/rdf/JulianDateTimeValueCleaner.php M repo/includes/store/ChangeDispatchCoordinator.php M repo/tests/phpunit/includes/ChangeOp/FingerprintChangeOpFactoryTest.php M repo/tests/phpunit/includes/api/GetEntitiesRedirectTest.php M repo/tests/phpunit/includes/rdf/DateValueCleanerTest.php M view/src/EntityIdFormatterFactory.php 18 files changed, 20 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/05/211705/1 diff --git a/client/tests/phpunit/includes/Usage/PageEntityUsagesTest.php b/client/tests/phpunit/includes/Usage/PageEntityUsagesTest.php index d923d26..9ab69b7 100644 --- a/client/tests/phpunit/includes/Usage/PageEntityUsagesTest.php +++ b/client/tests/phpunit/includes/Usage/PageEntityUsagesTest.php @@ -1,4 +1,5 @@ <?php + namespace Wikibase\Client\Tests\Usage; use PHPUnit_Framework_TestCase; diff --git a/client/tests/phpunit/includes/Usage/UsageAspectTransformerTest.php b/client/tests/phpunit/includes/Usage/UsageAspectTransformerTest.php index 7d7c041..0e0f1cf 100644 --- a/client/tests/phpunit/includes/Usage/UsageAspectTransformerTest.php +++ b/client/tests/phpunit/includes/Usage/UsageAspectTransformerTest.php @@ -1,4 +1,5 @@ <?php + namespace Wikibase\Client\Usage\Tests; use Wikibase\Client\Usage\EntityUsage; diff --git a/lib/includes/Reporting/NullMessageReporter.php b/lib/includes/Reporting/NullMessageReporter.php index 2296b60..ba39f1d 100644 --- a/lib/includes/Reporting/NullMessageReporter.php +++ b/lib/includes/Reporting/NullMessageReporter.php @@ -1,6 +1,7 @@ <?php namespace Wikibase\Lib\Reporting; + /** * Mock implementation of the MessageReporter interface that * does nothing with messages it receives. diff --git a/lib/includes/formatters/DispatchingValueFormatter.php b/lib/includes/formatters/DispatchingValueFormatter.php index 10aae2a..38ced97 100644 --- a/lib/includes/formatters/DispatchingValueFormatter.php +++ b/lib/includes/formatters/DispatchingValueFormatter.php @@ -1,4 +1,5 @@ <?php + namespace Wikibase\Lib; use DataValues\DataValue; diff --git a/lib/includes/formatters/OutputFormatSnakFormatterFactory.php b/lib/includes/formatters/OutputFormatSnakFormatterFactory.php index 1351c87..79c5084 100644 --- a/lib/includes/formatters/OutputFormatSnakFormatterFactory.php +++ b/lib/includes/formatters/OutputFormatSnakFormatterFactory.php @@ -1,5 +1,7 @@ <?php + namespace Wikibase\Lib; + use InvalidArgumentException; use RuntimeException; use ValueFormatters\FormatterOptions; diff --git a/lib/includes/formatters/OutputFormatValueFormatterFactory.php b/lib/includes/formatters/OutputFormatValueFormatterFactory.php index c43eb48..50a066f 100644 --- a/lib/includes/formatters/OutputFormatValueFormatterFactory.php +++ b/lib/includes/formatters/OutputFormatValueFormatterFactory.php @@ -1,5 +1,7 @@ <?php + namespace Wikibase\Lib; + use InvalidArgumentException; use RuntimeException; use ValueFormatters\FormatterOptions; diff --git a/lib/includes/modules/RepoAccessModule.php b/lib/includes/modules/RepoAccessModule.php index fd9c9d6..3f24932 100644 --- a/lib/includes/modules/RepoAccessModule.php +++ b/lib/includes/modules/RepoAccessModule.php @@ -1,6 +1,7 @@ <?php namespace Wikibase; + use ResourceLoaderContext; use ResourceLoaderModule; use Xml; diff --git a/lib/tests/phpunit/Validators/MembershipValidatorTest.php b/lib/tests/phpunit/Validators/MembershipValidatorTest.php index 60be618..9ff754c 100644 --- a/lib/tests/phpunit/Validators/MembershipValidatorTest.php +++ b/lib/tests/phpunit/Validators/MembershipValidatorTest.php @@ -1,4 +1,5 @@ <?php + namespace Wikibase\Test\Validators; use Wikibase\Validators\MembershipValidator; diff --git a/lib/tests/phpunit/Validators/NotEntityIdValidatorTest.php b/lib/tests/phpunit/Validators/NotEntityIdValidatorTest.php index 672d64b..e167230 100644 --- a/lib/tests/phpunit/Validators/NotEntityIdValidatorTest.php +++ b/lib/tests/phpunit/Validators/NotEntityIdValidatorTest.php @@ -1,4 +1,5 @@ <?php + namespace Wikibase\Test\Validators; use Wikibase\DataModel\Entity\BasicEntityIdParser; diff --git a/lib/tests/phpunit/Validators/NumberRangeValidatorTest.php b/lib/tests/phpunit/Validators/NumberRangeValidatorTest.php index f0f9366..0965b91 100644 --- a/lib/tests/phpunit/Validators/NumberRangeValidatorTest.php +++ b/lib/tests/phpunit/Validators/NumberRangeValidatorTest.php @@ -1,4 +1,5 @@ <?php + namespace Wikibase\Test\Validators; use Wikibase\Validators\NumberRangeValidator; diff --git a/lib/tests/phpunit/formatters/UnDeserializableValueFormatterTest.php b/lib/tests/phpunit/formatters/UnDeserializableValueFormatterTest.php index 7539c2f..00e9afc 100644 --- a/lib/tests/phpunit/formatters/UnDeserializableValueFormatterTest.php +++ b/lib/tests/phpunit/formatters/UnDeserializableValueFormatterTest.php @@ -1,4 +1,5 @@ <?php + namespace Wikibase\Lib\Test; use DataValues\UnDeserializableValue; diff --git a/repo/includes/rdf/DateTimeValueCleaner.php b/repo/includes/rdf/DateTimeValueCleaner.php index 0bbed3d..5c8f586 100644 --- a/repo/includes/rdf/DateTimeValueCleaner.php +++ b/repo/includes/rdf/DateTimeValueCleaner.php @@ -1,4 +1,5 @@ <?php + namespace Wikibase; use DataValues\TimeValue; diff --git a/repo/includes/rdf/JulianDateTimeValueCleaner.php b/repo/includes/rdf/JulianDateTimeValueCleaner.php index a601d73..a484f01 100644 --- a/repo/includes/rdf/JulianDateTimeValueCleaner.php +++ b/repo/includes/rdf/JulianDateTimeValueCleaner.php @@ -1,4 +1,5 @@ <?php + namespace Wikibase; use DataValues\TimeValue; diff --git a/repo/includes/store/ChangeDispatchCoordinator.php b/repo/includes/store/ChangeDispatchCoordinator.php index 59f604a..12e10ed 100644 --- a/repo/includes/store/ChangeDispatchCoordinator.php +++ b/repo/includes/store/ChangeDispatchCoordinator.php @@ -1,6 +1,7 @@ <?php namespace Wikibase\Store; + use Exception; use MWException; diff --git a/repo/tests/phpunit/includes/ChangeOp/FingerprintChangeOpFactoryTest.php b/repo/tests/phpunit/includes/ChangeOp/FingerprintChangeOpFactoryTest.php index 40c8556..7d69cec 100644 --- a/repo/tests/phpunit/includes/ChangeOp/FingerprintChangeOpFactoryTest.php +++ b/repo/tests/phpunit/includes/ChangeOp/FingerprintChangeOpFactoryTest.php @@ -1,6 +1,7 @@ <?php namespace Wikibase\Test; + use Wikibase\ChangeOp\FingerprintChangeOpFactory; /** diff --git a/repo/tests/phpunit/includes/api/GetEntitiesRedirectTest.php b/repo/tests/phpunit/includes/api/GetEntitiesRedirectTest.php index 45847f9..430f2d2 100644 --- a/repo/tests/phpunit/includes/api/GetEntitiesRedirectTest.php +++ b/repo/tests/phpunit/includes/api/GetEntitiesRedirectTest.php @@ -1,6 +1,7 @@ <?php namespace Wikibase\Test\Api; + use Wikibase\DataModel\Entity\EntityId; use Wikibase\DataModel\Entity\Item; use Wikibase\Lib\Store\EntityRedirect; diff --git a/repo/tests/phpunit/includes/rdf/DateValueCleanerTest.php b/repo/tests/phpunit/includes/rdf/DateValueCleanerTest.php index 5ac4b92..4be7e83 100644 --- a/repo/tests/phpunit/includes/rdf/DateValueCleanerTest.php +++ b/repo/tests/phpunit/includes/rdf/DateValueCleanerTest.php @@ -1,4 +1,5 @@ <?php + namespace Wikibase\Test; use DataValues\TimeValue; diff --git a/view/src/EntityIdFormatterFactory.php b/view/src/EntityIdFormatterFactory.php index 9ef174d..cb50c21 100644 --- a/view/src/EntityIdFormatterFactory.php +++ b/view/src/EntityIdFormatterFactory.php @@ -1,4 +1,5 @@ <?php + namespace Wikibase\View; use Wikibase\Lib\EntityIdFormatter; -- To view, visit https://gerrit.wikimedia.org/r/211705 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icf93d0219f73a5901b7e9eebd4bc3ce60a7d3d64 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
