Fjalapeno has uploaded a new change for review.
https://gerrit.wikimedia.org/r/211730
Change subject: Fix build and analyzer warnings
......................................................................
Fix build and analyzer warnings
Bug T99260
Change-Id: Ibc9fd00c9916371f01ce086eaafbd639782a0708
---
M Wikipedia/Categories/NSDate-Utilities.m
M Wikipedia/Custom Views/MenuLabel.m
M Wikipedia/Networking/Fetchers/BaseFetcher/FetcherBase.m
M Wikipedia/mw-utils/WikipediaAppUtils.m
4 files changed, 3 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/ios/wikipedia
refs/changes/30/211730/1
diff --git a/Wikipedia/Categories/NSDate-Utilities.m
b/Wikipedia/Categories/NSDate-Utilities.m
index a43b95f..ac8168a 100644
--- a/Wikipedia/Categories/NSDate-Utilities.m
+++ b/Wikipedia/Categories/NSDate-Utilities.m
@@ -94,7 +94,7 @@
}
// Must have a time interval under 1 week. Thanks @aclark
- return (abs([self timeIntervalSinceDate:aDate]) < D_WEEK);
+ return (fabs([self timeIntervalSinceDate:aDate]) < D_WEEK);
}
- (BOOL)isThisWeek {
diff --git a/Wikipedia/Custom Views/MenuLabel.m b/Wikipedia/Custom
Views/MenuLabel.m
index 64c0b6e..d0869b7 100644
--- a/Wikipedia/Custom Views/MenuLabel.m
+++ b/Wikipedia/Custom Views/MenuLabel.m
@@ -8,15 +8,11 @@
@interface MenuLabel ()
-@property (strong, nonatomic) NSString* text;
-
@property (strong, nonatomic) MenuLabel* label;
@property (nonatomic) CGFloat fontSize;
@property (nonatomic) BOOL fontBold;
-
-@property (nonatomic) UIEdgeInsets padding;
@end
diff --git a/Wikipedia/Networking/Fetchers/BaseFetcher/FetcherBase.m
b/Wikipedia/Networking/Fetchers/BaseFetcher/FetcherBase.m
index 4ba2e74..408b38d 100644
--- a/Wikipedia/Networking/Fetchers/BaseFetcher/FetcherBase.m
+++ b/Wikipedia/Networking/Fetchers/BaseFetcher/FetcherBase.m
@@ -62,7 +62,7 @@
}
- (NSDictionary*)dictionaryFromDataResponse:(id)responseObject {
- NSDictionary* output = @{};
+ NSDictionary* output = nil;
// Convert the raw NSData response to a dictionary.
if (![self isDataResponseValid:responseObject]) {
// Fake out an error if bad response received.
diff --git a/Wikipedia/mw-utils/WikipediaAppUtils.m
b/Wikipedia/mw-utils/WikipediaAppUtils.m
index 086a629..384c06b 100644
--- a/Wikipedia/mw-utils/WikipediaAppUtils.m
+++ b/Wikipedia/mw-utils/WikipediaAppUtils.m
@@ -95,7 +95,7 @@
}
+ (NSString*)relativeTimestamp:(NSDate*)date {
- NSTimeInterval interval = abs([date timeIntervalSinceNow]);
+ NSTimeInterval interval = fabs([date timeIntervalSinceNow]);
double minutes = interval / 60.0;
double hours = minutes / 60.0;
double days = hours / 24.0;
--
To view, visit https://gerrit.wikimedia.org/r/211730
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibc9fd00c9916371f01ce086eaafbd639782a0708
Gerrit-PatchSet: 1
Gerrit-Project: apps/ios/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Fjalapeno <cfl...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
