Phuedx has uploaded a new change for review.
https://gerrit.wikimedia.org/r/211734
Change subject: Fix "Create account password mismatch message" test
......................................................................
Fix "Create account password mismatch message" test
* Add the SpecialUserLoginPage error_box element, consistent with the
recently added warning_box element
* Use the element in the "Then I should see an error indicating they do
not match" step
Change-Id: I53c831c3f876db2414e8fdca992fb44d17a75f06
---
M
tests/browser/features/step_definitions/create_account_failure_messages_steps.rb
M tests/browser/features/support/pages/special_userlogin_page.rb
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/34/211734/1
diff --git
a/tests/browser/features/step_definitions/create_account_failure_messages_steps.rb
b/tests/browser/features/step_definitions/create_account_failure_messages_steps.rb
index be9de08..6a4bc8b 100644
---
a/tests/browser/features/step_definitions/create_account_failure_messages_steps.rb
+++
b/tests/browser/features/step_definitions/create_account_failure_messages_steps.rb
@@ -8,7 +8,7 @@
end
Then(/^I should see an error indicating they do not match$/) do
- expect(on(SpecialUserLoginPage).feedback).to match('The passwords you
entered do not match')
+ expect(on(SpecialUserLoginPage).error_box).to match('The passwords you
entered do not match')
end
Then(/^I should still be on the sign-up page$/) do
diff --git a/tests/browser/features/support/pages/special_userlogin_page.rb
b/tests/browser/features/support/pages/special_userlogin_page.rb
index 4e8520a..92db741 100644
--- a/tests/browser/features/support/pages/special_userlogin_page.rb
+++ b/tests/browser/features/support/pages/special_userlogin_page.rb
@@ -6,7 +6,6 @@
h1(:first_heading, id: 'section_0')
- div(:feedback, class: 'alert error')
button(:login, id: 'wpLoginAttempt')
text_field(:username, name: 'wpName')
text_field(:password, name: 'wpPassword')
@@ -15,6 +14,7 @@
button(:signup_submit, id: 'wpCreateaccount')
a(:create_account_link, text: 'Create account')
div(:message_box, class: 'warningbox')
+ div(:error_box, class: 'errorbox')
a(:password_reset, css: '.mw-userlogin-help')
# signup specific
--
To view, visit https://gerrit.wikimedia.org/r/211734
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I53c831c3f876db2414e8fdca992fb44d17a75f06
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Phuedx <g...@samsmith.io>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
