jenkins-bot has submitted this change and it was merged.
Change subject: Small typo fixes for ve.dm.APIResultsProvider
......................................................................
Small typo fixes for ve.dm.APIResultsProvider
Make sure fetch limit is actually stored by using its setter,
use setters for all relevant properties, and fix a small
typo in documentation.
Change-Id: I1c2f7d5f2f38f4b08e3ec1fe6af01e36f6b26dde
---
M src/dm/ve.dm.APIResultsProvider.js
1 file changed, 5 insertions(+), 5 deletions(-)
Approvals:
Jforrester: Looks good to me, but someone else must approve
Esanders: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/dm/ve.dm.APIResultsProvider.js
b/src/dm/ve.dm.APIResultsProvider.js
index 81e53c8..294a8b2 100644
--- a/src/dm/ve.dm.APIResultsProvider.js
+++ b/src/dm/ve.dm.APIResultsProvider.js
@@ -27,10 +27,10 @@
config = config || {};
this.setAPIurl( apiurl );
- this.fetchLimit = config.fetchLimit || 30;
- this.lang = config.lang;
- this.offset = config.offset || 0;
- this.ajaxSettings = config.ajaxSettings || {};
+ this.setDefaultFetchLimit( config.fetchLimit || 30 );
+ this.setLang( config.lang );
+ this.setOffset( config.offset || 0 );
+ this.setAjaxSettings( config.ajaxSettings || {} );
this.staticParams = config.staticParams || {};
this.userParams = config.userParams || {};
@@ -103,7 +103,7 @@
};
/**
- * Get the user-inputted dybamic data parameters sent to the API
+ * Get the user-inputted dynamic data parameters sent to the API
*
* @returns {Object} Data parameters
*/
--
To view, visit https://gerrit.wikimedia.org/r/211749
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1c2f7d5f2f38f4b08e3ec1fe6af01e36f6b26dde
Gerrit-PatchSet: 2
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo <mor...@gmail.com>
Gerrit-Reviewer: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
