Pwirth has submitted this change and it was merged. Change subject: BSApiExtJSStoreBase: changed behavior when filter value is invalid ......................................................................
BSApiExtJSStoreBase: changed behavior when filter value is invalid As stated by pwirth in [1] it might be better if a filter does not apply when its value is invalid [1] https://gerrit.wikimedia.org/r/#/c/211686/2/includes/api/BSApiExtJSStoreBase.php Change-Id: Idc203e47db516fc3f631c7a1dbe71999e6ff543e --- M includes/api/BSApiExtJSStoreBase.php 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Pwirth: Verified; Looks good to me, approved diff --git a/includes/api/BSApiExtJSStoreBase.php b/includes/api/BSApiExtJSStoreBase.php index abfba09..9af6019 100644 --- a/includes/api/BSApiExtJSStoreBase.php +++ b/includes/api/BSApiExtJSStoreBase.php @@ -304,7 +304,7 @@ */ public function filterString( $oFilter, $aDataSet ) { if( !is_string( $oFilter->value ) ) { - return false; //TODO: Warning + return true; //TODO: Warning } $sFieldValue = $aDataSet->{$oFilter->field}; $sFilterValue = $oFilter->value; @@ -339,7 +339,7 @@ */ public function filterNumeric( $oFilter, $aDataSet ) { if( !is_numeric( $oFilter->value ) ) { - return false; //TODO: Warning + return true; //TODO: Warning } $sFieldValue = $aDataSet->{$oFilter->field}; $iFilterValue = (int) $oFilter->value; @@ -364,7 +364,7 @@ */ public function filterList( $oFilter, $aDataSet ) { if( !is_array( $oFilter->value ) ) { - return false; //TODO: Warning + return true; //TODO: Warning } $aFieldValues = $aDataSet->{$oFilter->field}; if( empty( $aFieldValues ) ) { -- To view, visit https://gerrit.wikimedia.org/r/212261 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc203e47db516fc3f631c7a1dbe71999e6ff543e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/BlueSpiceFoundation Gerrit-Branch: master Gerrit-Owner: Robert Vogel <vo...@hallowelt.biz> Gerrit-Reviewer: Mglaser <gla...@hallowelt.biz> Gerrit-Reviewer: Pwirth <wi...@hallowelt.biz> Gerrit-Reviewer: Tweichart <weich...@hallowelt.biz> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
