Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/212268
Change subject: Expand class level doc of RdfBuilder classes ...................................................................... Expand class level doc of RdfBuilder classes This fixes the FIXMEs from I538f33a. Bug: T92515 Change-Id: I129247427969d348514619b17c14953fee247daf --- M repo/includes/rdf/EntityRdfBuilder.php M repo/includes/rdf/FullStatementRdfBuilder.php M repo/includes/rdf/TruthyStatementRdfBuilder.php 3 files changed, 11 insertions(+), 6 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/68/212268/1 diff --git a/repo/includes/rdf/EntityRdfBuilder.php b/repo/includes/rdf/EntityRdfBuilder.php index ebe7fb6..abf0979 100644 --- a/repo/includes/rdf/EntityRdfBuilder.php +++ b/repo/includes/rdf/EntityRdfBuilder.php @@ -5,7 +5,8 @@ use Wikibase\DataModel\Entity\EntityDocument; /** - * Interface for an RDF mapping for (some aspect of) wikibase entities. + * Interface for an RDF mapping for wikibase entities. It's up to the implementation to decide which + * aspects of the provided entities it will output to RDF. * * @since 0.5 * diff --git a/repo/includes/rdf/FullStatementRdfBuilder.php b/repo/includes/rdf/FullStatementRdfBuilder.php index 48f0948..8f8260c 100644 --- a/repo/includes/rdf/FullStatementRdfBuilder.php +++ b/repo/includes/rdf/FullStatementRdfBuilder.php @@ -11,14 +11,14 @@ use Wikibase\DataModel\Statement\Statement; use Wikibase\DataModel\Statement\StatementList; use Wikibase\DataModel\StatementListProvider; -use Wikibase\Rdf\DedupeBag; -use Wikibase\Rdf\NullDedupeBag; use Wikimedia\Purtle\RdfWriter; /** - * Fully reified RDF mapping for wikibase statements. + * Fully RDF mapping for wikibase statements, including non-"truthy" and deprecated values. * This does not output simple statements. If both forms (simple and full) are desired, - * use SimpleStatementRdfBuilder in addition to FullStatementRdfBuilder. + * use TruthyStatementRdfBuilder in addition to FullStatementRdfBuilder. + * + * @see TruthyStatementRdfBuilder * * @since 0.5 * diff --git a/repo/includes/rdf/TruthyStatementRdfBuilder.php b/repo/includes/rdf/TruthyStatementRdfBuilder.php index 0706591..de58cff 100644 --- a/repo/includes/rdf/TruthyStatementRdfBuilder.php +++ b/repo/includes/rdf/TruthyStatementRdfBuilder.php @@ -12,7 +12,11 @@ use Wikimedia\Purtle\RdfWriter; /** - * "Truthy" RDF mapping for wikibase statements. + * "Truthy" RDF mapping for wikibase statements. The concept of "truthy" or "best" statements per + * property only incorporates values that have the best non-deprecated rank. If an RDF output must + * contain all values, use FullStatementRdfBuilder instead. + * + * @see FullStatementRdfBuilder * * @since 0.5 * -- To view, visit https://gerrit.wikimedia.org/r/212268 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I129247427969d348514619b17c14953fee247daf Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
