Bartosz Dziewoński has uploaded a new change for review. https://gerrit.wikimedia.org/r/212890
Change subject: Remove redundant line-height declarations from elements.css ...................................................................... Remove redundant line-height declarations from elements.css Elements.css declares line-height of 1.5em for certain common elements, like ol, ul and dd. These are redundant as each skin already declares the same line-height for the content, and all elements inherit this line-height from the body. At the same time, these declaration override the content line-height of 1.6em set in Vector, creating inconsistencies that cannot be 'hacked' away. Removing these line-height declarations has no impact, other then making the typography refresh actually work as intended. Bug: T66653 Change-Id: I5b682a9527294e96f3999773724cbf8fb9631197 (cherry picked from commit 531ed153f31b73c3e0a18209519bffd401e66157) --- M resources/src/mediawiki.skinning/elements.css 1 file changed, 0 insertions(+), 5 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/90/212890/1 diff --git a/resources/src/mediawiki.skinning/elements.css b/resources/src/mediawiki.skinning/elements.css index eb57abb..8140d1a 100644 --- a/resources/src/mediawiki.skinning/elements.css +++ b/resources/src/mediawiki.skinning/elements.css @@ -141,7 +141,6 @@ p { margin: .4em 0 .5em 0; - line-height: 1.5em; } p img { @@ -149,14 +148,12 @@ } ul { - line-height: 1.5em; list-style-type: square; margin: .3em 0 0 1.6em; padding: 0; } ol { - line-height: 1.5em; margin: .3em 0 0 3.2em; padding: 0; list-style-image: none; @@ -177,7 +174,6 @@ } dd { - line-height: 1.5em; margin-left: 1.6em; margin-bottom: .1em; } @@ -215,7 +211,6 @@ border: 1px solid #2f6fab; margin: 1em 0 1em 0; padding: 0 1em 1em; - line-height: 1.5em; } fieldset.nested { -- To view, visit https://gerrit.wikimedia.org/r/212890 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5b682a9527294e96f3999773724cbf8fb9631197 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: REL1_25 Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com> Gerrit-Reviewer: Edokter <er...@darcoury.nl> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits