Aude has uploaded a new change for review. https://gerrit.wikimedia.org/r/212922
Change subject: Add map to nearby fragment [DRAFT] ...................................................................... Add map to nearby fragment [DRAFT] work in progress..... Change-Id: I423745164ce8694d14099ea9aa0b2a05a141c8c3 --- A wikipedia/res/drawable-hdpi/ic_map_white.png A wikipedia/res/drawable-mdpi/ic_map_white.png A wikipedia/res/drawable-xhdpi/ic_map_white.png A wikipedia/res/drawable-xxhdpi/ic_map_white.png M wikipedia/res/menu/menu_nearby.xml M wikipedia/res/values/strings.xml M wikipedia/src/main/java/org/wikipedia/nearby/NearbyFragment.java 7 files changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia refs/changes/22/212922/1 diff --git a/wikipedia/res/drawable-hdpi/ic_map_white.png b/wikipedia/res/drawable-hdpi/ic_map_white.png new file mode 100644 index 0000000..b0d69ee --- /dev/null +++ b/wikipedia/res/drawable-hdpi/ic_map_white.png Binary files differ diff --git a/wikipedia/res/drawable-mdpi/ic_map_white.png b/wikipedia/res/drawable-mdpi/ic_map_white.png new file mode 100644 index 0000000..d74bc3f --- /dev/null +++ b/wikipedia/res/drawable-mdpi/ic_map_white.png Binary files differ diff --git a/wikipedia/res/drawable-xhdpi/ic_map_white.png b/wikipedia/res/drawable-xhdpi/ic_map_white.png new file mode 100644 index 0000000..ecd83d6 --- /dev/null +++ b/wikipedia/res/drawable-xhdpi/ic_map_white.png Binary files differ diff --git a/wikipedia/res/drawable-xxhdpi/ic_map_white.png b/wikipedia/res/drawable-xxhdpi/ic_map_white.png new file mode 100644 index 0000000..d2b4d26 --- /dev/null +++ b/wikipedia/res/drawable-xxhdpi/ic_map_white.png Binary files differ diff --git a/wikipedia/res/menu/menu_nearby.xml b/wikipedia/res/menu/menu_nearby.xml index e282fae..ee7b6cf 100644 --- a/wikipedia/res/menu/menu_nearby.xml +++ b/wikipedia/res/menu/menu_nearby.xml @@ -3,6 +3,10 @@ <menu xmlns:android="http://schemas.android.com/apk/res/android"; xmlns:app="http://schemas.android.com/apk/res-auto"; > + <item android:id="@+id/menu_nearby_map" + android:icon="@drawable/ic_map_white" + android:title="@string/menu_map_nearby" + app:showAsAction="ifRoom" /> <item android:id="@+id/menu_refresh_nearby" android:icon="@drawable/ic_refresh" android:title="@string/menu_update_nearby" diff --git a/wikipedia/res/values/strings.xml b/wikipedia/res/values/strings.xml index fa1ec40..06176b5 100644 --- a/wikipedia/res/values/strings.xml +++ b/wikipedia/res/values/strings.xml @@ -42,6 +42,7 @@ <string name="saved_pages_search_empty_message">No pages found matching your query.</string> <string name="nav_item_nearby">Nearby</string> + <string name="menu_map_nearby">Map</string> <string name="menu_update_nearby">Update nearby</string> <string name="nearby_empty_title">No nearby pages here!</string> <string name="nearby_empty_message">When you move to a new location, try refreshing this page to learn more about what\'s around you.</string> diff --git a/wikipedia/src/main/java/org/wikipedia/nearby/NearbyFragment.java b/wikipedia/src/main/java/org/wikipedia/nearby/NearbyFragment.java index 7acc87c..0cef9e0 100644 --- a/wikipedia/src/main/java/org/wikipedia/nearby/NearbyFragment.java +++ b/wikipedia/src/main/java/org/wikipedia/nearby/NearbyFragment.java @@ -529,6 +529,8 @@ setRefreshingState(true); requestLocationUpdates(); return true; + case R.id.menu_nearby_map: + return true; case R.id.menu_metric_imperial: setImperialUnits(!showImperial); adapter.notifyDataSetInvalidated(); -- To view, visit https://gerrit.wikimedia.org/r/212922 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I423745164ce8694d14099ea9aa0b2a05a141c8c3 Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Aude <aude.w...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
