jenkins-bot has submitted this change and it was merged. Change subject: [BrowserTest] Fixing the broken test for bullets ......................................................................
[BrowserTest] Fixing the broken test for bullets The test was broken for using wrong identifier in the test. Updated them correctly. Change-Id: I46a9c4ebaf1b44f0db24f2b64dcd863697011203 --- M modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Zfilipin: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb b/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb index 5e84e3d..8ff9153 100644 --- a/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb +++ b/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb @@ -44,7 +44,7 @@ span(:confirm_switch_discard, text: 'Discard changes') span(:option_to_always_show_TOC, css: 'div.oo-ui-fieldLayout-align-top:nth-child(4) > div:nth-child(2) > div:nth-child(2) > div:nth-child(1) > div:nth-child(1) > a:nth-child(1) > span:nth-child(2)') div(:content, class: 've-ce-branchNode') - span(:decrease_indentation, class: 'oo-ui-iconElement-icon oo-ui-icon-outdent-list') + span(:decrease_indentation, class: 'oo-ui-iconElement-icon oo-ui-icon-outdent') text_area(:describe_change, index: 0) table(:diff_view, css: '.ve-ui-mwSaveDialog-viewer table.diff') div(:disabled_save_button, css: 'div.ve-init-mw-viewPageTarget-toolbar .oo-ui-toolbar-actions > div.oo-ui-flaggedElement-progressive.oo-ui-widget-disabled') @@ -67,7 +67,7 @@ span(:hamburger_menu, class: 'oo-ui-iconElement-icon oo-ui-icon-menu') div(:heading_dropdown_menus, class: 'oo-ui-toolGroup-tools oo-ui-clippableElement-clippable', index: 1) div(:window_frame, css: 'div.oo-ui-window-setup > div.oo-ui-window-frame') - span(:increase_indentation, class: 'oo-ui-iconElement-icon oo-ui-icon-indent-list') + span(:increase_indentation, class: 'oo-ui-iconElement-icon oo-ui-icon-indent') div(:indentation_button, class: 've-test-toolbar-structure') div(:indentation_pull_down, css: '.ve-test-toolbar-structure .oo-ui-clippableElement-clippable') span(:insert_citation, css: '.ve-ui-nodeDialog > div:nth-child(1) > div:nth-child(1) > div:nth-child(3) > div:nth-child(1) > a:nth-child(1) > span:nth-child(2) @@ -176,7 +176,7 @@ span(:ve_media_menu, class: 'oo-ui-iconElement-icon oo-ui-icon-picture') span(:ve_more_markup_options, css: 'span.oo-ui-tool-name-more-fewer:nth-child(10) > a:nth-child(1) > span:nth-child(2)') a(:ve_more_references_options, css: '.ve-test-toolbar-insert > div:nth-child(2) > span:nth-child(8) > a:nth-child(1)') - span(:ve_numbering, class: 'oo-ui-iconElement-icon oo-ui-icon-number-list') + span(:ve_numbering, class: 'oo-ui-iconElement-icon oo-ui-icon-listNumbered') span(:ve_references, class: 'oo-ui-iconElement-icon oo-ui-icon-references') span(:ve_strikethrough, class: 'oo-ui-iconElement-icon oo-ui-icon-strikethrough-s') span(:ve_subscript, class: 'oo-ui-iconElement-icon oo-ui-icon-subscript') -- To view, visit https://gerrit.wikimedia.org/r/213282 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I46a9c4ebaf1b44f0db24f2b64dcd863697011203 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Ryasmeen <[email protected]> Gerrit-Reviewer: Dduvall <[email protected]> Gerrit-Reviewer: Etonkovidova <[email protected]> Gerrit-Reviewer: Zfilipin <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
