Gilles has uploaded a new change for review.
https://gerrit.wikimedia.org/r/213811
Change subject: Explicitly define module position
......................................................................
Explicitly define module position
Style modules currently added through addModuleStyles default
to being in the head ("top" position). This is an unhealthy default,
since only critical styles that are needed at pageload should be
in the head. In order to be able to switch the default to "bottom",
existing module positions have to be defined explicitly.
Bug: T97410
Change-Id: I87556b8a214f96af475e7acdc5e2e7be357b6b53
---
M includes/Resources.php
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/11/213811/1
diff --git a/includes/Resources.php b/includes/Resources.php
index f035b62..bc224f3 100644
--- a/includes/Resources.php
+++ b/includes/Resources.php
@@ -178,6 +178,7 @@
),
'skins.minerva.alpha.styles' => $wgMFResourceFileModuleBoilerplate +
array(
+ 'position' => 'top',
'styles' => array(
'less/ui.alpha.less',
),
@@ -223,6 +224,7 @@
),
),
'skins.minerva.alpha.images' => $wgMFResourceFileModuleBoilerplate +
array(
+ 'position' => 'bottom',
'class' => 'ResourceLoaderImageModule',
'selector' => '.mw-ui-icon-{name}:before',
'images' => array(
@@ -1605,7 +1607,9 @@
),
// These are NOT empty see $wgResourceModuleSkinStyles.
- 'mobile.special.history.styles' =>
$wgMFMobileSpecialPageResourceBoilerplate + array(),
+ 'mobile.special.history.styles' =>
$wgMFMobileSpecialPageResourceBoilerplate + array(
+ 'position' => 'top',
+ ),
'mobile.special.userprofile.styles' =>
$wgMFMobileSpecialPageResourceBoilerplate + array(),
'mobile.special.uploads.scripts' => $wgMFResourceFileModuleBoilerplate
+ array(
--
To view, visit https://gerrit.wikimedia.org/r/213811
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I87556b8a214f96af475e7acdc5e2e7be357b6b53
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Gilles <gdu...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
