jenkins-bot has submitted this change and it was merged.
Change subject: ButtonWidget: Fix not having tabindex updated when
enabled/disabled
......................................................................
ButtonWidget: Fix not having tabindex updated when enabled/disabled
The "onDisable" method provided by ButtonWidget was overriding the one
provided by TabIndexedElement. Rename the latter.
Bug: T100480
Change-Id: I0644419b43cb082866579427ed929bc646967afb
---
M src/elements/TabIndexedElement.js
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
Jforrester: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/src/elements/TabIndexedElement.js
b/src/elements/TabIndexedElement.js
index 5c2151a..d87a9f6 100644
--- a/src/elements/TabIndexedElement.js
+++ b/src/elements/TabIndexedElement.js
@@ -45,7 +45,7 @@
this.tabIndex = null;
// Events
- this.connect( this, { disable: 'onDisable' } );
+ this.connect( this, { disable: 'onTabIndexedElementDisable' } );
// Initialization
this.setTabIndex( config.tabIndex );
@@ -124,7 +124,7 @@
* @private
* @param {boolean} disabled Element is disabled
*/
-OO.ui.TabIndexedElement.prototype.onDisable = function () {
+OO.ui.TabIndexedElement.prototype.onTabIndexedElementDisable = function () {
this.updateTabIndex();
};
--
To view, visit https://gerrit.wikimedia.org/r/213962
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0644419b43cb082866579427ed929bc646967afb
Gerrit-PatchSet: 3
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Anomie <bjor...@wikimedia.org>
Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
