Mholloway has uploaded a new change for review.
https://gerrit.wikimedia.org/r/214417
Change subject: Fix margins on link preview dialog 2 (display correctly on
tablets)
......................................................................
Fix margins on link preview dialog 2 (display correctly on tablets)
Bug: T100677
Change-Id: I540570cb54b93fcbfad35540d0901ed6f97d0307
---
M wikipedia/res/layout/dialog_link_preview_2.xml
M wikipedia/src/main/java/org/wikipedia/page/linkpreview/LinkPreviewDialog.java
2 files changed, 9 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/17/214417/1
diff --git a/wikipedia/res/layout/dialog_link_preview_2.xml
b/wikipedia/res/layout/dialog_link_preview_2.xml
index dcd9236..6456ea3 100755
--- a/wikipedia/res/layout/dialog_link_preview_2.xml
+++ b/wikipedia/res/layout/dialog_link_preview_2.xml
@@ -26,7 +26,12 @@
<LinearLayout
android:layout_width="match_parent"
android:layout_height="match_parent"
- android:layout_margin="@dimen/activity_horizontal_margin"
+ android:layout_marginTop="@dimen/activity_vertical_margin"
+ android:layout_marginBottom="@dimen/activity_vertical_margin"
+ android:layout_marginLeft="@dimen/activity_horizontal_margin"
+ android:layout_marginRight="@dimen/activity_horizontal_margin"
+ android:layout_marginStart="@dimen/activity_horizontal_margin"
+ android:layout_marginEnd="@dimen/activity_horizontal_margin"
android:orientation="vertical">
<LinearLayout
diff --git
a/wikipedia/src/main/java/org/wikipedia/page/linkpreview/LinkPreviewDialog.java
b/wikipedia/src/main/java/org/wikipedia/page/linkpreview/LinkPreviewDialog.java
index e7509ca..c050a31 100755
---
a/wikipedia/src/main/java/org/wikipedia/page/linkpreview/LinkPreviewDialog.java
+++
b/wikipedia/src/main/java/org/wikipedia/page/linkpreview/LinkPreviewDialog.java
@@ -254,9 +254,9 @@
}
if (!TextUtils.isEmpty(contents.getTitle().getThumbUrl()) &&
app.showImages()) {
Picasso.with(getActivity())
- .load(contents.getTitle().getThumbUrl())
- .placeholder(layoutToggle == 1 ?
Utils.getThemedAttributeId(getActivity(), R.attr.lead_image_drawable) :
R.drawable.link_preview_gradient)
- .error(Utils.getThemedAttributeId(getActivity(),
R.attr.lead_image_drawable))
+ .load(contents.getTitle().getThumbUrl())
+ .placeholder(layoutToggle == 1 ?
Utils.getThemedAttributeId(getActivity(), R.attr.lead_image_drawable) :
R.drawable.link_preview_gradient)
+ .error(Utils.getThemedAttributeId(getActivity(),
R.attr.lead_image_drawable))
.into(previewImage, new Callback() {
@Override
public void onSuccess() {
--
To view, visit https://gerrit.wikimedia.org/r/214417
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I540570cb54b93fcbfad35540d0901ed6f97d0307
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mholloway <mhollo...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
