jenkins-bot has submitted this change and it was merged.
Change subject: Stop showing/counting same user multiple times
......................................................................
Stop showing/counting same user multiple times
Change-Id: Ibf84fe7c66c016896f31d9aee717523e9b0fa4cd
---
M WhosOnlineSpecialPage.php
1 file changed, 5 insertions(+), 3 deletions(-)
Approvals:
Lewis Cawte: Looks good to me, approved
jenkins-bot: Verified
diff --git a/WhosOnlineSpecialPage.php b/WhosOnlineSpecialPage.php
index 36a398c..59effa6 100644
--- a/WhosOnlineSpecialPage.php
+++ b/WhosOnlineSpecialPage.php
@@ -21,7 +21,7 @@
return array(
'tables' => array( 'online' ),
'fields' => array( 'username' ),
- 'options' => array( 'ORDER BY' => 'timestamp DESC' ),
+ 'options' => array( 'ORDER BY' => 'timestamp DESC',
'GROUP BY' => 'username' ),
'conds' => $wgWhosOnlineShowAnons
? array()
: array( 'userid != 0' )
@@ -63,7 +63,8 @@
'online',
'COUNT(*) AS cnt',
'userid != 0',
- __METHOD__
+ __METHOD__,
+ 'GROUP BY username'
);
$users = (int) $row->cnt;
@@ -100,7 +101,8 @@
'online',
'COUNT(*) AS cnt',
'userid = 0',
- __METHOD__
+ __METHOD__,
+ 'GROUP BY username'
);
$guests = (int) $row->cnt;
--
To view, visit https://gerrit.wikimedia.org/r/197225
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf84fe7c66c016896f31d9aee717523e9b0fa4cd
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/WhosOnline
Gerrit-Branch: master
Gerrit-Owner: BrandonCsSanders <bran...@getserene.com>
Gerrit-Reviewer: BrandonCsSanders <bran...@getserene.com>
Gerrit-Reviewer: Isarra <zhoris...@gmail.com>
Gerrit-Reviewer: Jack Phoenix <j...@countervandalism.net>
Gerrit-Reviewer: Lewis Cawte <le...@lewiscawte.me>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
