Ejegg has uploaded a new change for review.
https://gerrit.wikimedia.org/r/215245
Change subject: Quit setting default email in form
......................................................................
Quit setting default email in form
Old forms relied on a special case to keep the default value out of
the placeholder. I think we don't need to set it at all in DI.
Change-Id: Iaf742da324c372842e41e5458390f2df38d0967e
---
M gateway_common/DonationData.php
1 file changed, 0 insertions(+), 6 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface
refs/changes/45/215245/1
diff --git a/gateway_common/DonationData.php b/gateway_common/DonationData.php
index 669f08c..84cce42 100644
--- a/gateway_common/DonationData.php
+++ b/gateway_common/DonationData.php
@@ -674,18 +674,12 @@
* Normalize email
* Check regular name, and horrible old name for values (preferring the
* reasonable name over the legacy version)
- * Set the value to 'nob...@wikimedia.org' if nothing has been entered.
*/
protected function setEmail() {
// Look at the old style value (because that's canonical if
populated first)
$email = $this->getVal( 'emailAdd' );
if ( is_null( $email ) ) {
$email = $this->getVal( 'email' );
- }
-
- if ( is_null( $email ) ) {
- // We still have nothing, populate with default
- $email = 'nob...@wikimedia.org';
}
$this->setVal( 'email', $email );
--
To view, visit https://gerrit.wikimedia.org/r/215245
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaf742da324c372842e41e5458390f2df38d0967e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Ejegg <eeggles...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
