jenkins-bot has submitted this change and it was merged.
Change subject: demo: Avoid exception when switching modes if surface is
destroyed
......................................................................
demo: Avoid exception when switching modes if surface is destroyed
Change-Id: I6cf3070babc0fa812ae0b1d43a5202eb6a4c94fa
---
M demos/ve/ve.demo.SurfaceContainer.js
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/demos/ve/ve.demo.SurfaceContainer.js
b/demos/ve/ve.demo.SurfaceContainer.js
index 7a628f8..6e90ac1 100644
--- a/demos/ve/ve.demo.SurfaceContainer.js
+++ b/demos/ve/ve.demo.SurfaceContainer.js
@@ -257,7 +257,10 @@
this.$surfaceWrapper.empty().append( this.surface.$element.parent() )
.hide().slideDown().promise().done( function () {
- container.surface.getView().focus();
+ // Check surface still exists
+ if ( container.surface ) {
+ container.surface.getView().focus();
+ }
} );
};
--
To view, visit https://gerrit.wikimedia.org/r/215344
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6cf3070babc0fa812ae0b1d43a5202eb6a4c94fa
Gerrit-PatchSet: 3
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits