Ori.livneh has submitted this change and it was merged.
Change subject: ResourceLoader::filter: use APC when running under HHVM
......................................................................
ResourceLoader::filter: use APC when running under HHVM
On HHVM, (a) the cost of a ResourceLoader::filter cache miss is smaller, and
(b) APC is faster and more resilient than PHP's. These two things tilt the
scales in favor of using APC rather than Memcached.
Change-Id: I30b490e5bc815849d4b0bb06f2dbbb68825ed225
---
M includes/resourceloader/ResourceLoader.php
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Ori.livneh: Verified; Looks good to me, approved
diff --git a/includes/resourceloader/ResourceLoader.php
b/includes/resourceloader/ResourceLoader.php
index bebdf2d..ba13bc3 100644
--- a/includes/resourceloader/ResourceLoader.php
+++ b/includes/resourceloader/ResourceLoader.php
@@ -195,9 +195,8 @@
if ( !$options['cache'] ) {
$result = $this->applyFilter( $filter, $data );
} else {
- // Use CACHE_ANYTHING since filtering is very slow
compared to DB queries
$key = wfMemcKey( 'resourceloader', 'filter', $filter,
self::$filterCacheVersion, md5( $data ) );
- $cache = wfGetCache( CACHE_ANYTHING );
+ $cache = wfGetCache( wfIsHHVM() ? CACHE_ACCEL :
CACHE_ANYTHING );
$cacheEntry = $cache->get( $key );
if ( is_string( $cacheEntry ) ) {
wfIncrStats( "rl-$filter-cache-hits" );
--
To view, visit https://gerrit.wikimedia.org/r/215766
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I30b490e5bc815849d4b0bb06f2dbbb68825ed225
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.26wmf8
Gerrit-Owner: Ori.livneh <o...@wikimedia.org>
Gerrit-Reviewer: Ori.livneh <o...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
