jenkins-bot has submitted this change and it was merged.
Change subject: Preserve scroll position in
OO.ui.Element.static.reconsiderScrollbars
......................................................................
Preserve scroll position in OO.ui.Element.static.reconsiderScrollbars
The saga continues.
Bug: T98847
Bug: T98506
Change-Id: I2a5b73f6b6f4af53b37d5d2536b0e8c0641d336e
---
M src/Element.js
1 file changed, 7 insertions(+), 1 deletion(-)
Approvals:
Anomie: Looks good to me, but someone else must approve
Trevor Parscal: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/Element.js b/src/Element.js
index 127eb50..360f1a5 100644
--- a/src/Element.js
+++ b/src/Element.js
@@ -567,7 +567,10 @@
* @param {HTMLElement} el Element to reconsider the scrollbars on
*/
OO.ui.Element.static.reconsiderScrollbars = function ( el ) {
- var i, len, nodes = [];
+ var i, len, scrollLeft, scrollTop, nodes = [];
+ // Save scroll position
+ scrollLeft = el.scrollLeft;
+ scrollTop = el.scrollTop;
// Detach all children
while ( el.firstChild ) {
nodes.push( el.firstChild );
@@ -579,6 +582,9 @@
for ( i = 0, len = nodes.length; i < len; i++ ) {
el.appendChild( nodes[ i ] );
}
+ // Restore scroll position (no-op if scrollbars disappeared)
+ el.scrollLeft = scrollLeft;
+ el.scrollTop = scrollTop;
};
/* Methods */
--
To view, visit https://gerrit.wikimedia.org/r/210339
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2a5b73f6b6f4af53b37d5d2536b0e8c0641d336e
Gerrit-PatchSet: 2
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Anomie <bjor...@wikimedia.org>
Gerrit-Reviewer: Trevor Parscal <tpars...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
