Soeren.oldag has uploaded a new change for review.
https://gerrit.wikimedia.org/r/216075
Change subject: It is now documented which function parameters are expected to
be sanitized HTML, and when functions return HTML.
......................................................................
It is now documented which function parameters are expected to be sanitized
HTML, and when functions return HTML.
Change-Id: I9d24a6fa5d890bf15655759fdf84a66812bbbf02
---
M specials/SpecialCrossCheck.php
M specials/SpecialExternalDbs.php
2 files changed, 8 insertions(+), 8 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikidataQualityExternalValidation
refs/changes/75/216075/1
diff --git a/specials/SpecialCrossCheck.php b/specials/SpecialCrossCheck.php
index aad996f..d3ae2ee 100755
--- a/specials/SpecialCrossCheck.php
+++ b/specials/SpecialCrossCheck.php
@@ -235,7 +235,7 @@
/**
* Builds infobox with explanation for this special page
*
- * @return string
+ * @return string HTML
*/
private function buildInfoBox() {
$externalDbLink = Linker::specialLink( 'ExternalDbs',
'wbqev-externaldbs' );
@@ -262,7 +262,7 @@
*
* @throws InvalidArgumentException
*
- * @return string
+ * @return string HTML
*/
private function buildNotice( $message, $error = false ) {
$cssClasses = 'wbqev-crosscheck-notice';
@@ -285,7 +285,7 @@
*
* @param EntityId $entityId
*
- * @return string
+ * @return string HTML
*/
private function buildResultHeader( EntityId $entityId ) {
$entityLink = sprintf( '%s (%s)',
@@ -305,7 +305,7 @@
*
* @param CrossCheckResultList $results
*
- * @return string
+ * @return string HTML
*/
private function buildSummary( $results ) {
$statuses = array ();
@@ -342,7 +342,7 @@
*
* @throws InvalidArgumentException
*
- * @return string
+ * @return string HTML
*/
private function formatStatus( $status ) {
$messageName = "wbqev-crosscheck-status-" . strtolower( $status );
@@ -368,7 +368,7 @@
*
* @throws InvalidArgumentException
*
- * @return string
+ * @return string HTML
*/
private function formatDataValues( $dataValues, $linking = true,
$separator = ', ' ) {
if ( $dataValues instanceof DataValue ) {
@@ -394,7 +394,7 @@
/**
* @param Traversable $results
*
- * @return string
+ * @return string HTML
*/
private function buildResultTable( $results ) {
$table = new HtmlTable(
diff --git a/specials/SpecialExternalDbs.php b/specials/SpecialExternalDbs.php
index 5009d68..161de49 100755
--- a/specials/SpecialExternalDbs.php
+++ b/specials/SpecialExternalDbs.php
@@ -131,7 +131,7 @@
*
* @param array $dumpMetaInformationGroup
*
- * @return string
+ * @return array
*/
private function getRowGroup( array $dumpMetaInformationGroup ) {
$rows = array ();
--
To view, visit https://gerrit.wikimedia.org/r/216075
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9d24a6fa5d890bf15655759fdf84a66812bbbf02
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikidataQualityExternalValidation
Gerrit-Branch: master
Gerrit-Owner: Soeren.oldag <soeren_ol...@freenet.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
