Santhosh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/216623
Change subject: Fix js error in the CX contribution menu when VE is triggered
......................................................................
Fix js error in the CX contribution menu when VE is triggered
The $dialog of callout instance of trigger is null till callout
is shown. If the callout was not shown before VE trigger, accessing
$dialog can create js error.
Bug: T101421
Change-Id: I2ae3dc93ba76d9ca816d64d811a00cacd193373c
---
M modules/campaigns/ext.cx.campaigns.contributionsmenu.js
1 file changed, 10 insertions(+), 13 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation
refs/changes/23/216623/1
diff --git a/modules/campaigns/ext.cx.campaigns.contributionsmenu.js
b/modules/campaigns/ext.cx.campaigns.contributionsmenu.js
index 33ef2fe..c4c889b 100644
--- a/modules/campaigns/ext.cx.campaigns.contributionsmenu.js
+++ b/modules/campaigns/ext.cx.campaigns.contributionsmenu.js
@@ -60,12 +60,9 @@
return $item;
}
- function showInvitation() {
- var $trigger,
- $myContributions, $myTranslations, $myUploads,
+ function attachMenu( $trigger ) {
+ var $myContributions, $myTranslations, $myUploads,
$menu, callout;
-
- $trigger = $( '#pt-mycontris a' );
$myContributions = $( '<li>' )
.addClass( 'cx-campaign-contributions' )
@@ -110,18 +107,18 @@
}
$( function () {
- var blacklist = mw.config.get(
'wgContentTranslationBrowserBlacklist' );
+ var $trigger, blacklist = mw.config.get(
'wgContentTranslationBrowserBlacklist' );
if ( !$.client.test( blacklist, null, true ) ) {
- showInvitation();
+ $trigger = $( '#pt-mycontris' );
- // Show it after creating a new article using VE
+ attachMenu( $trigger );
+
+ // Change the menu when creating a new article using VE
mw.hook( 've.activationComplete' ).add( function () {
- var $trigger;
-
- $trigger = $( '#pt-mycontris a' );
- $trigger.data( 'callout' ).$dialog.find(
'li.cx-campaign-translations' )
- .replaceWith( getTranslationsItem() );
+ // Rebuild menu.
+ $trigger.removeData( 'callout' );
+ attachMenu( $trigger );
} );
}
} );
--
To view, visit https://gerrit.wikimedia.org/r/216623
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2ae3dc93ba76d9ca816d64d811a00cacd193373c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Santhosh <santhosh.thottin...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
