Divec has uploaded a new change for review. https://gerrit.wikimedia.org/r/217221
Change subject: Allow DM-identical range changes to cause a repaint ...................................................................... Allow DM-identical range changes to cause a repaint Bug: T101523 Change-Id: Iae9866f03e6bd086048f413ff813cf0dd17f889b --- M src/ce/ve.ce.Surface.js M src/ce/ve.ce.SurfaceObserver.js 2 files changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor refs/changes/21/217221/1 diff --git a/src/ce/ve.ce.Surface.js b/src/ce/ve.ce.Surface.js index 4377f75..b4ece3e 100644 --- a/src/ce/ve.ce.Surface.js +++ b/src/ce/ve.ce.Surface.js @@ -2532,7 +2532,7 @@ * @param {ve.Range|null} newRange */ ve.ce.Surface.prototype.onSurfaceObserverRangeChange = function ( oldRange, newRange ) { - if ( oldRange && oldRange.equalsSelection( newRange ) ) { + if ( !newRange.isCollapsed() && oldRange && oldRange.equalsSelection( newRange ) ) { // Ignore when the newRange is just a flipped oldRange return; } diff --git a/src/ce/ve.ce.SurfaceObserver.js b/src/ce/ve.ce.SurfaceObserver.js index 222e192..ab151f7 100644 --- a/src/ce/ve.ce.SurfaceObserver.js +++ b/src/ce/ve.ce.SurfaceObserver.js @@ -230,6 +230,9 @@ } if ( newState.selectionChanged && emitChanges ) { + // Caution: selectionChanged is true if the CE selection is different, which can + // be the case even if the DM selection is unchanged. So the following line can + // emit a rangeChange event with identical oldState and newState. this.emit( 'rangeChange', ( oldState ? oldState.veRange : null ), -- To view, visit https://gerrit.wikimedia.org/r/217221 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iae9866f03e6bd086048f413ff813cf0dd17f889b Gerrit-PatchSet: 1 Gerrit-Project: VisualEditor/VisualEditor Gerrit-Branch: master Gerrit-Owner: Divec <da...@sheetmusic.org.uk> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits