Mattflaschen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/217425
Change subject: Cleanup API calls in LQT->Flow
......................................................................
Cleanup API calls in LQT->Flow
* Use rawcontinue to avoid inapplicable warning.
* Remove invalid 'limit' parameter.
* Make method call match case so it's greppable.
Change-Id: I9b55c6486115ab9f93548f6a71fcdcd18260fa19
---
M includes/Import/LiquidThreadsApi/CachedData.php
M includes/Import/LiquidThreadsApi/Source.php
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow
refs/changes/25/217425/1
diff --git a/includes/Import/LiquidThreadsApi/CachedData.php
b/includes/Import/LiquidThreadsApi/CachedData.php
index 1818a12..c7f70b9 100644
--- a/includes/Import/LiquidThreadsApi/CachedData.php
+++ b/includes/Import/LiquidThreadsApi/CachedData.php
@@ -173,6 +173,6 @@
*/
class CachedPageData extends CachedApiData {
protected function retrieve( array $ids ) {
- return $this->backend->retrievePageDataByID( $ids );
+ return $this->backend->retrievePageDataById( $ids );
}
}
diff --git a/includes/Import/LiquidThreadsApi/Source.php
b/includes/Import/LiquidThreadsApi/Source.php
index 0e7c344..8280068 100644
--- a/includes/Import/LiquidThreadsApi/Source.php
+++ b/includes/Import/LiquidThreadsApi/Source.php
@@ -226,6 +226,7 @@
'action' => 'query',
'list' => 'threads',
'thprop' =>
'id|subject|page|parent|ancestor|created|modified|author|summaryid|type|rootid|replies',
+ 'rawcontinue' => 1, // We're doing continuation a
different way, but this avoids a warning.
'format' => 'json',
'limit' => ApiBase::LIMIT_BIG1,
);
@@ -311,7 +312,6 @@
'rvlimit' => 5000,
'rvdir' => 'newer',
'continue' => '',
- 'limit' => ApiBase::LIMIT_BIG1,
);
$data = $this->apiCall( $conditions );
--
To view, visit https://gerrit.wikimedia.org/r/217425
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9b55c6486115ab9f93548f6a71fcdcd18260fa19
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <mflasc...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
