BearND has uploaded a new change for review.
https://gerrit.wikimedia.org/r/217450
Change subject: Fix issue where app goes to main page on device rotation
......................................................................
Fix issue where app goes to main page on device rotation
When a config change occurred it saved a null value for the "language" in
onSaveInstanceState.
Subsequently, when the activity was recreated, it used the null value and
compared it with
app.getAppOrSystemLanguageCode(), which is always set to a non-null string (in
my case "en").
Why is this affecting the page we're on? Because we use the language value to
determine if
the language has changed and if we need to reset the site, which also goes to
the sites main page.
Thus, it looks like we have to go back to Start, and don't collect our $400.
Bug: T102097
Change-Id: Ib2a4b8fcd66f601017ff486484ec3bcfdd5a27af
---
M wikipedia/src/main/java/org/wikipedia/page/PageActivity.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/50/217450/1
diff --git a/wikipedia/src/main/java/org/wikipedia/page/PageActivity.java
b/wikipedia/src/main/java/org/wikipedia/page/PageActivity.java
index 5b6653e..37a0c0e 100644
--- a/wikipedia/src/main/java/org/wikipedia/page/PageActivity.java
+++ b/wikipedia/src/main/java/org/wikipedia/page/PageActivity.java
@@ -804,7 +804,7 @@
outState.putBoolean("themeChooserShowing",
themeChooser.isShowing());
}
outState.putBoolean("isSearching", isSearching());
- outState.putString(LANGUAGE_CODE_BUNDLE_KEY, app.getAppLanguageCode());
+ outState.putString(LANGUAGE_CODE_BUNDLE_KEY,
app.getAppOrSystemLanguageCode());
}
@Override
--
To view, visit https://gerrit.wikimedia.org/r/217450
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib2a4b8fcd66f601017ff486484ec3bcfdd5a27af
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: BearND <bsitzm...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
