Tamslo has uploaded a new change for review.
https://gerrit.wikimedia.org/r/217493
Change subject: Fixed tests after implementing icons
......................................................................
Fixed tests after implementing icons
(Sorry ... ^^)
Change-Id: I85a011d29cb7bbdfbe965e2bdf263d7f683855b5
---
M includes/Violations/ConstraintViolationFormatter.php
M tests/phpunit/Violations/ConstraintViolationFormatterTest.php
2 files changed, 6 insertions(+), 2 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikidataQualityConstraints
refs/changes/93/217493/1
diff --git a/includes/Violations/ConstraintViolationFormatter.php
b/includes/Violations/ConstraintViolationFormatter.php
index 6b435b3..bf79bc3 100755
--- a/includes/Violations/ConstraintViolationFormatter.php
+++ b/includes/Violations/ConstraintViolationFormatter.php
@@ -91,7 +91,8 @@
//TODO: ConstraintTypeEntityId as EntityId when implemented
(currently string)
- switch ( $violation->getConstraintTypeEntityId() ) {
+ $constraintType = $violation->getConstraintTypeEntityId();
+ switch ( $constraintType ) {
case 'Commons Link':
$iconClass =
ConstraintViolationFormatter::COMMONS_ICON_CLASS;
break;
diff --git a/tests/phpunit/Violations/ConstraintViolationFormatterTest.php
b/tests/phpunit/Violations/ConstraintViolationFormatterTest.php
index db1c8f8..e5550b1 100755
--- a/tests/phpunit/Violations/ConstraintViolationFormatterTest.php
+++ b/tests/phpunit/Violations/ConstraintViolationFormatterTest.php
@@ -153,7 +153,7 @@
private function getViolationMock( $constraintId = null,
$additionalInformation = null ) {
$mock = $this->getMockBuilder( 'WikibaseQuality\Violations\Violation' )
- ->setMethods( array( 'getConstraintId', 'getAdditionalInfo' ) )
+ ->setMethods( array( 'getConstraintId', 'getAdditionalInfo',
'getConstraintTypeEntityId' ) )
->disableOriginalConstructor()
->getMock();
$mock->expects( $this->any() )
@@ -162,6 +162,9 @@
$mock->expects( $this->any() )
->method( 'getAdditionalInfo' )
->willReturn( $additionalInformation );
+ $mock->expects( $this->any() )
+ ->method( 'getConstraintTypeEntityId' )
+ ->willReturn( 'Range' );
return $mock;
}
--
To view, visit https://gerrit.wikimedia.org/r/217493
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I85a011d29cb7bbdfbe965e2bdf263d7f683855b5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikidataQualityConstraints
Gerrit-Branch: master
Gerrit-Owner: Tamslo <tamaraslosa...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
