jenkins-bot has submitted this change and it was merged.
Change subject: build: Run jsonlint too
......................................................................
build: Run jsonlint too
We recursively lint all JSON files in the directory tree, except those
in node_modules.
jsonlint intentionally runs before banana-checker because it gives
better error messages if en.json or qqq.json have syntax errors.
Change-Id: Ibbca22da16d50295fd48a9c2b0d35a68c15551e9
---
M Gruntfile.js
M package.json
2 files changed, 12 insertions(+), 3 deletions(-)
Approvals:
Krinkle: Looks good to me, approved
jenkins-bot: Verified
diff --git a/Gruntfile.js b/Gruntfile.js
index 8d54d16..2c0f12c 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -7,11 +7,19 @@
/*jshint node:true */
module.exports = function ( grunt ) {
grunt.loadNpmTasks( 'grunt-banana-checker' );
+ grunt.loadNpmTasks( 'grunt-jsonlint' );
+
var conf = grunt.file.readJSON( 'extension.json' );
grunt.initConfig( {
- banana: conf.MessagesDirs
+ banana: conf.MessagesDirs,
+ jsonlint: {
+ all: [
+ '**/*.json',
+ '!node_modules/**'
+ ]
+ }
} );
- grunt.registerTask( 'test', [ 'banana' ] );
+ grunt.registerTask( 'test', [ 'jsonlint', 'banana' ] );
grunt.registerTask( 'default', 'test' );
};
diff --git a/package.json b/package.json
index 8488bf5..5593147 100644
--- a/package.json
+++ b/package.json
@@ -9,6 +9,7 @@
"devDependencies": {
"grunt": "0.4.5",
"grunt-cli": "0.1.13",
- "grunt-banana-checker": "0.2.2"
+ "grunt-banana-checker": "0.2.2",
+ "grunt-jsonlint": "1.0.4"
}
}
--
To view, visit https://gerrit.wikimedia.org/r/217451
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibbca22da16d50295fd48a9c2b0d35a68c15551e9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GlobalUserPage
Gerrit-Branch: master
Gerrit-Owner: Legoktm <legoktm.wikipe...@gmail.com>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: Legoktm <legoktm.wikipe...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
