Bartosz Dziewoński has uploaded a new change for review.
https://gerrit.wikimedia.org/r/218284
Change subject: RadioSelectInputWidget: Unbreak form submission in JS version
......................................................................
RadioSelectInputWidget: Unbreak form submission in JS version
I honestly have no idea what I was thinking when I put this .empty()
call here. It removes this.$input from DOM, which means this widget's
value would not be submitted with forms.
Change-Id: If68f04a2fa20e7c03763898ab80cf39b5e6cb182
---
M src/widgets/RadioSelectInputWidget.js
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/84/218284/1
diff --git a/src/widgets/RadioSelectInputWidget.js
b/src/widgets/RadioSelectInputWidget.js
index 1c33455..d400370 100644
--- a/src/widgets/RadioSelectInputWidget.js
+++ b/src/widgets/RadioSelectInputWidget.js
@@ -43,7 +43,6 @@
this.setOptions( config.options || [] );
this.$element
.addClass( 'oo-ui-radioSelectInputWidget' )
- .empty()
.append( this.radioSelectWidget.$element );
};
--
To view, visit https://gerrit.wikimedia.org/r/218284
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If68f04a2fa20e7c03763898ab80cf39b5e6cb182
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
