BBlack has uploaded a new change for review.
https://gerrit.wikimedia.org/r/218287
Change subject: HTTPS: Remove 302 support
......................................................................
HTTPS: Remove 302 support
Our original over-conservative plans involved using a 302
initially and then switching to 301, on the theory that the 302
might make it easier to revert a bad traffic pattern quickly. In
practice, there doesn't seem to be any real benefit from the
302-first strategy, so we're skipping that step going forward and
don't need this block anymore.
Change-Id: I0cf27312399b6d9f5f4af7dd9a37914366546311
---
M modules/varnish/templates/vcl/wikimedia.vcl.erb
1 file changed, 1 insertion(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/87/218287/1
diff --git a/modules/varnish/templates/vcl/wikimedia.vcl.erb
b/modules/varnish/templates/vcl/wikimedia.vcl.erb
index 86328e9..a88bf8f 100644
--- a/modules/varnish/templates/vcl/wikimedia.vcl.erb
+++ b/modules/varnish/templates/vcl/wikimedia.vcl.erb
@@ -179,14 +179,8 @@
}
}
-// *** HTTPS error code - implements 301/302 response for recv code
+// *** HTTPS error code - implements 301 response for recv code
sub https_error_redirect {
- if (obj.status == 752) {
- set obj.http.Location = req.http.Location;
- set obj.status = 302;
- set obj.http.Content-Length = "0"; // T64245
- return(deliver);
- }
if (obj.status == 751) {
set obj.http.Location = req.http.Location;
set obj.status = 301;
--
To view, visit https://gerrit.wikimedia.org/r/218287
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0cf27312399b6d9f5f4af7dd9a37914366546311
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: BBlack <bbl...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
