Adamw has submitted this change and it was merged. Change subject: Enabling Arbitrary Central Notice Buckets ......................................................................
Enabling Arbitrary Central Notice Buckets We can now have any power of two buckets in central notice. I also have a change here which makes the preview throw less errors when previewing.. (which probably should be it's own change but meh) --- !!! --- This change requires that if more than 8 buckets are ever provided that we apply a schema change to change the not_buckets column to something other than tinyint(1) --- !!! --- Change-Id: Id7df0b570a2b83c562bf945d4ef62d44e982409d --- M CentralNotice.php M CentralNoticePager.php M TemplatePager.php M api/ApiCentralNoticeAllocations.php M includes/BannerChooser.php M modules/ext.centralNotice.bannerController/bannerController.js M modules/ext.centralNotice.interface/centralnotice.js M special/SpecialBannerAllocation.php M special/SpecialBannerLoader.php M special/SpecialCentralNotice.php M special/SpecialNoticeTemplate.php 11 files changed, 137 insertions(+), 64 deletions(-) Approvals: Adamw: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/35841 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id7df0b570a2b83c562bf945d4ef62d44e982409d Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/CentralNotice Gerrit-Branch: master Gerrit-Owner: Mwalker <[email protected]> Gerrit-Reviewer: Adamw <[email protected]> Gerrit-Reviewer: Mwalker <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
