Faidon Liambotis has uploaded a new change for review.
https://gerrit.wikimedia.org/r/218594
Change subject: HTTPS: redirect commons, take 2
......................................................................
HTTPS: redirect commons, take 2
Redirect Commons again, but this time make an exception for MediaWiki
User-Agents, to avoid breaking InstantCommons for everyone, for now.
Change-Id: Ib81c193f9dfc43625d7863505897d4e21c628414
---
M modules/varnish/templates/vcl/wikimedia.vcl.erb
1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/94/218594/1
diff --git a/modules/varnish/templates/vcl/wikimedia.vcl.erb
b/modules/varnish/templates/vcl/wikimedia.vcl.erb
index 6f54923..b474b9f 100644
--- a/modules/varnish/templates/vcl/wikimedia.vcl.erb
+++ b/modules/varnish/templates/vcl/wikimedia.vcl.erb
@@ -175,6 +175,15 @@
set req.http.Location = "https://"; +
req.http.Host + req.url;
error 751 "TLS Redirect";
}
+
+ // Redirect Commons but make an exception for MediaWiki
User-Agents,
+ // as these are usually the InstantCommons feature,
which is buggy with
+ // redirects. See T102566 for context.
+ if (req.http.Host ~ "(?i)^commons\.wikimedia\.org$" &&
+ req.http.User-Agent !~ "^MediaWiki/" ) {
+ set req.http.Location = "https://"; +
req.http.Host + req.url;
+ error 751 "TLS Redirect";
+ }
}
}
}
--
To view, visit https://gerrit.wikimedia.org/r/218594
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib81c193f9dfc43625d7863505897d4e21c628414
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon Liambotis <fai...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
