jenkins-bot has submitted this change and it was merged.
Change subject: Remove placeholder status from citations before inserting
......................................................................
Remove placeholder status from citations before inserting
Otherwise they never appears in the reference list.
Bug: T102265
Change-Id: Ifd5e00cf88ff4e27380a2060b4e3d2f2c3d8bacb
---
M modules/ve.ui.CiteFromIdInspector.js
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve.ui.CiteFromIdInspector.js
b/modules/ve.ui.CiteFromIdInspector.js
index 7d85232..8c4b27d 100644
--- a/modules/ve.ui.CiteFromIdInspector.js
+++ b/modules/ve.ui.CiteFromIdInspector.js
@@ -328,6 +328,9 @@
this.results[ index ].transclusionModel.insertTransclusionNode(
fragment );
if ( this.inDialog !== 'reference' ) {
+ // Remove placeholder status
+ this.getFragment().changeAttributes( { placeholder:
false } );
+
// HACK: Scorch the earth - this is only needed because
without it,
// the reference list won't re-render properly, and can
be removed
// once someone fixes that
--
To view, visit https://gerrit.wikimedia.org/r/218612
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifd5e00cf88ff4e27380a2060b4e3d2f2c3d8bacb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Citoid
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Mvolz <mv...@wikimedia.org>
Gerrit-Reviewer: Nirzar <npangar...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
