Esanders has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/218642

Change subject: Rename basic reference tool after moving to 'insert' menu
......................................................................

Rename basic reference tool after moving to 'insert' menu

The tool is titled 'Basic' which makes no sense out of context.

Change-Id: I390cc256cae341d8f5a52d98968047d2d85acaf5
---
M extension.json
M i18n/en.json
M i18n/qqq.json
M modules/ve.ui.CiteFromIdInspectorTool.js
4 files changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Citoid 
refs/changes/42/218642/1

diff --git a/extension.json b/extension.json
index 335a7af..d2cbb23 100644
--- a/extension.json
+++ b/extension.json
@@ -50,6 +50,7 @@
                                "citoid-citefromiddialog-title",
                                
"citoid-citefromiddialog-use-general-error-message",
                                "citoid-citefromidtool-title",
+                               "citoid-dialogbutton-reference-full-tooltip",
                                "citoid-template-type-map.json",
                                "citoid-unknown-error"
                        ],
diff --git a/i18n/en.json b/i18n/en.json
index ef023ac..94087a3 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -16,6 +16,7 @@
        "citoid-citefromiddialog-title": "Add a citation",
        "citoid-citefromiddialog-use-general-error-message": "We couldn't make 
a citation for you. You can create one manually using the 
\"{{int:citoid-citefromiddialog-mode-manual}}\" tab above.",
        "citoid-citefromidtool-title": "Cite",
+       "citoid-dialogbutton-reference-full-tooltip": "Basic reference",
        "citoid-desc": "Provides access points between the citoid service and 
MediaWiki",
        "citoid-unknown-error": "An unknown error has occured that prevented us 
from creating a citation. Please try again later."
 }
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 98487d6..0f29421 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -22,6 +22,7 @@
        "citoid-citefromiddialog-title": "The title displayed on the dialog",
        "citoid-citefromiddialog-use-general-error-message": "Label notifying 
the user there was a problem creating their reference, and offering to use the 
full citation tool.\n* $1 – link to open the citation dialog; link label: 
{{msg-mw|citoid-citefromiddialog-mode-manual}}",
        "citoid-citefromidtool-title": "Label for the button to add a citation 
in the toolbar\n{{Identical|Cite}}",
+       "citoid-dialogbutton-reference-full-tooltip": "Label for the basic 
reference toolbar button after being moved to the 'insert' group.",
        "citoid-desc": 
"{{desc|name=Citoid|url=https://www.mediawiki.org/wiki/Citoid}}";,
        "citoid-unknown-error": "Error message indicating that the service to 
create citations has returned an error or is temporarily malfunctioning, asking 
the user to try again later."
 }
diff --git a/modules/ve.ui.CiteFromIdInspectorTool.js 
b/modules/ve.ui.CiteFromIdInspectorTool.js
index d628636..07d8666 100644
--- a/modules/ve.ui.CiteFromIdInspectorTool.js
+++ b/modules/ve.ui.CiteFromIdInspectorTool.js
@@ -27,6 +27,9 @@
        // HACK: Replace the previous cite group with the citoid tool.
        ve.init.mw.Target.static.toolbarGroups[ citeIndex ] = { include: [ 
'citefromid' ] };
 
+       // HACK: Replace the 'Basic' tool title now that it lives in the 
'insert' toolgroup
+       ve.ui.MWReferenceDialogTool.static.title = OO.ui.deferMsg( 
'citoid-dialogbutton-reference-full-tooltip' );
+
        /**
         * MediaWiki UserInterface cite from ID inspector tool.
         *

-- 
To view, visit https://gerrit.wikimedia.org/r/218642
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I390cc256cae341d8f5a52d98968047d2d85acaf5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Citoid
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to