Legoktm has uploaded a new change for review.
https://gerrit.wikimedia.org/r/218947
Change subject: Don't fail to create the tarball if "composer install" fails
......................................................................
Don't fail to create the tarball if "composer install" fails
Also improve error logging while we're at it
Bug: T102418
Change-Id: Ib1c2b78c749ba017d162d36d6e0a353a770f8424
---
M nightly.py
1 file changed, 7 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/labs/tools/extdist
refs/changes/47/218947/1
diff --git a/nightly.py b/nightly.py
index d07806a..072b16e 100644
--- a/nightly.py
+++ b/nightly.py
@@ -24,6 +24,7 @@
import os
import subprocess
import sys
+import traceback
import urllib
@@ -177,8 +178,11 @@
continue
if self.COMPOSER and os.path.exists('composer.json'):
logging.debug('Running composer install for %s' % ext)
- self.shell_exec([self.COMPOSER, 'install'])
- pass
+ try:
+ self.shell_exec([self.COMPOSER, 'install'])
+ except subprocess.CalledProcessError:
+ logging.error(traceback.format_exc())
+ logging.error('composer install failed')
# Create a 'version' file with basic info about the tarball
with open('version', 'w') as f:
f.write('%s: %s\n' % (ext, branch))
@@ -231,6 +235,7 @@
try:
self.update_extension(repo)
except:
+ logging.error(traceback.format_exc())
logging.error('Updating %s failed, skipping' % repo)
logging.info('Finished update of all %s!' % self.REPO_TYPE)
--
To view, visit https://gerrit.wikimedia.org/r/218947
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib1c2b78c749ba017d162d36d6e0a353a770f8424
Gerrit-PatchSet: 1
Gerrit-Project: labs/tools/extdist
Gerrit-Branch: master
Gerrit-Owner: Legoktm <legoktm.wikipe...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
