Markus Kroetzsch has submitted this change and it was merged. Change subject: Fixed some interface issues in SMW_setup.php ......................................................................
Fixed some interface issues in SMW_setup.php Changes: * Register "--backend" as an option *with parameters*; this makes "--backend Name" work (otherwise only "--backend=Name" works) and it improves error handling * Check if provided backend is a valid class name; prevents PHP errors on typos * Respect --quiet by using the output() method instead of print, and by passing on the information given by isQuiet() to store operations * Fix spelling and format of some documentation Patchset 2: Fixing remaining uses of "echo" that ignored --quiet. Patchset 3: Fixed more typos ("promt") and modified behaviour when given invalid storage class (report error & die) Change-Id: I3e2ada69a0bb23ee42e993cee3ad4a6ef7ffd65e --- M maintenance/SMW_setup.php 1 file changed, 34 insertions(+), 27 deletions(-) Approvals: Markus Kroetzsch: Verified Foxtrott: Looks good to me, but someone else must approve Jeroen De Dauw: Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/36162 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e2ada69a0bb23ee42e993cee3ad4a6ef7ffd65e Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch <mar...@semantic-mediawiki.org> Gerrit-Reviewer: Daniel Werner <daniel.wer...@wikimedia.de> Gerrit-Reviewer: Denny Vrandecic <denny.vrande...@wikimedia.de> Gerrit-Reviewer: Foxtrott <s7ep...@gmail.com> Gerrit-Reviewer: Jeroen De Dauw <jeroended...@gmail.com> Gerrit-Reviewer: Kghbln <mediaw...@kghoffmeyer.de> Gerrit-Reviewer: Markus Kroetzsch <mar...@semantic-mediawiki.org> Gerrit-Reviewer: Mwjames <jamesin.hongkon...@gmail.com> Gerrit-Reviewer: Nischayn22 <nischay...@gmail.com> Gerrit-Reviewer: Yaron Koren <yaro...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits