Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/219303
Change subject: build: Remove references to non-existent "javascripts/"
directory
......................................................................
build: Remove references to non-existent "javascripts/" directory
Follows-up 13aff2e53bdbd6.
Change-Id: I44530e3e8971d36a3f343323c72bf79348204ebb
---
M .jscsrc
M .jshintignore
M Makefile
M includes/MobileFrontend.hooks.php
4 files changed, 0 insertions(+), 9 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/03/219303/1
diff --git a/.jscsrc b/.jscsrc
index df0ce1a..c64f899 100644
--- a/.jscsrc
+++ b/.jscsrc
@@ -8,7 +8,6 @@
"requireParamTypes": true,
"checkRedundantParams": true
},
- "excludeFiles": ["javascripts/externals/**/*.js", "javascripts/README.md"],
"additionalRules": [
"node_modules/jscs-jsdoc/lib/rules/*.js"
],
diff --git a/.jshintignore b/.jshintignore
index 57e0837..2a59849 100644
--- a/.jshintignore
+++ b/.jshintignore
@@ -1,5 +1,3 @@
-javascripts/externals
-javascripts/README.md
tests/js/fixtures.js
tests/externals
styleguide-template
diff --git a/Makefile b/Makefile
index c5f9957..cf176c8 100644
--- a/Makefile
+++ b/Makefile
@@ -41,9 +41,6 @@
nodecheck:
@dev-scripts/nodecheck.sh
-jsbeautify: nodecheck ## Check the JavaScript coding style
- @find javascripts -type f -name "*.js" -not -path "**externals**" -exec
node_modules/.bin/js-beautify -r {} \;
-
jscs: nodecheck ## Check the JavaScript coding style
@grunt jscs
diff --git a/includes/MobileFrontend.hooks.php
b/includes/MobileFrontend.hooks.php
index 0236b65..510dbc3 100644
--- a/includes/MobileFrontend.hooks.php
+++ b/includes/MobileFrontend.hooks.php
@@ -277,9 +277,6 @@
$templates = array();
foreach ( $module['scripts'] as $script ) {
$testFile = 'tests/' . dirname( $script
) . '/test_' . basename( $script );
- // for javascripts folder (being
deprecated)
- $testFile = str_replace(
'tests/javascripts/', 'tests/qunit/', $testFile );
-
// For resources folder
$testFile = str_replace(
'tests/resources/', 'tests/qunit/', $testFile );
// if a test file exists for a given JS
file, add it
--
To view, visit https://gerrit.wikimedia.org/r/219303
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I44530e3e8971d36a3f343323c72bf79348204ebb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
