Daniel Werner has submitted this change and it was merged.

Change subject: JavaScript template engine function returning jQuery object
......................................................................


JavaScript template engine function returning jQuery object

Instead of a string, mw.templates() returns a jQuery object and checks if the 
constructed HTML would actually be valid. Comes along with some QUnit tests.

Change-Id: I72e2e22e1627bab98acf0562d2399bd74b109085
---
M lib/resources/jquery.wikibase/jquery.wikibase.claimlistview.js
M lib/resources/templates.js
M lib/resources/wikibase.ui.AliasesEditTool.js
M lib/resources/wikibase.ui.PropertyEditTool.js
M lib/resources/wikibase.ui.SiteLinksEditTool.js
M lib/resources/wikibase.ui.Toolbar.Button.js
M lib/tests/qunit/templates.tests.js
M repo/resources/wikibase.ui.entityViewInit.js
8 files changed, 288 insertions(+), 43 deletions(-)

Approvals:
  Daniel Werner: Verified; Looks good to me, approved


--
To view, visit https://gerrit.wikimedia.org/r/36178
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I72e2e22e1627bab98acf0562d2399bd74b109085
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater <henning.sna...@wikimedia.de>
Gerrit-Reviewer: Daniel Werner <daniel.wer...@wikimedia.de>
Gerrit-Reviewer: Henning Snater <henning.sna...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to