Subramanya Sastry has uploaded a new change for review.

Change subject: Improve upon 942ea55 and 92df97d by ignoring stray newlines.
......................................................................

Improve upon 942ea55 and 92df97d by ignoring stray newlines.

* 92df97d added ability to ignore stray white-space when handling
  fostering of entire template content out of tables without
  knowing why it was being done really.

* And 942ea55 added ability to migrate start metas closer to
  the content being emitted.  However, it could get thwarted
  by stray white-space (almost always a single newline token).

* This commit fixes both places to ingore a single newline token
  (common fix).  It is unclear if it is "safe" to do this for
  generic white-space rather than just a single newline.
  [No change to RTing of en:SS_Oxfordshire from 92df97d fix]

* Fixes one more wt2wt test.

* "Fixes" this test case that wasn't rt-ing before
  *a
  **b
  ***c{{echo|

  }}

  But, this is not a true fix because the meta-tag migration
  effectively moves the "{{...}}" outside the list.  Hence, an
  extra newline is added before the {{ on serialization.
  But, this kind of use-case should be rare enough that the extra
  newline should be acceptable -- but selective serialization
  should take care of it).  This example was indeed conceived
  as a way to show that start-tag meta migration frion 92df97d
  can change template position in RT output in certain cases
  but also to argue the "harmlessness" of the change ;).

* Cleaned out the removeTrailingNewslinesFromParagraphs code
  completely.

Change-Id: I5517e892dc554f40584888c4aac1a46f279ba143
---
M js/lib/mediawiki.DOMPostProcessor.js
1 file changed, 15 insertions(+), 48 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid 
refs/changes/06/36206/1
--
To view, visit https://gerrit.wikimedia.org/r/36206
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5517e892dc554f40584888c4aac1a46f279ba143
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to