Ori.livneh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/220014

Change subject: If unable to shell out to Pygments, emit a warning and fall 
back to plain text.
......................................................................

If unable to shell out to Pygments, emit a warning and fall back to plain text.

Change-Id: I8beb0367405e8ea70385134e03302e8bd3ab91ff
---
M SyntaxHighlight_GeSHi.class.php
1 file changed, 10 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SyntaxHighlight_GeSHi 
refs/changes/14/220014/1

diff --git a/SyntaxHighlight_GeSHi.class.php b/SyntaxHighlight_GeSHi.class.php
index aec7a47..0bb779f 100644
--- a/SyntaxHighlight_GeSHi.class.php
+++ b/SyntaxHighlight_GeSHi.class.php
@@ -143,6 +143,16 @@
                        $lexer = null;
                }
 
+               if ( wfShellExecDisabled() !== false ) {
+                       wfWarn(
+                               'MediaWiki determined that it cannot invoke 
Pygments. ' .
+                               'As a result, SyntaxHighlight_GeSHi will not 
perform any syntax highlighting. ' .
+                               'See the debug log for details: ' .
+                               
'https://www.mediawiki.org/wiki/Manual:$wgDebugLogFile'
+                       );
+                       $lexer = null;
+               }
+
                $inline = isset( $args['enclose'] ) && $args['enclose'] === 
'span';
                $attrs = array( 'class' => self::HIGHLIGHT_CSS_CLASS );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/220014
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8beb0367405e8ea70385134e03302e8bd3ab91ff
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SyntaxHighlight_GeSHi
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <o...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to