Catrope has submitted this change and it was merged. Change subject: (bug 42555) Fixed onUpdate over-writing in ve.ce.HeadingNode ......................................................................
(bug 42555) Fixed onUpdate over-writing in ve.ce.HeadingNode When the content rendering stuff was moved to ve.ce.ContentBranchNode the onUpdate methods being used to update the DOM wrapper in ve.ce.HeadingNode was overlooked, so heading were not rendered on update anymore. Change-Id: I994b8c43123c3cd02b9a550d5d7eac7d5052418e --- M modules/ve/ce/ve.ce.ContentBranchNode.js M modules/ve/test/ce/ve.ce.ContentBranchNode.test.js 2 files changed, 31 insertions(+), 25 deletions(-) Approvals: Catrope: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/36059 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I994b8c43123c3cd02b9a550d5d7eac7d5052418e Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Trevor Parscal <[email protected]> Gerrit-Reviewer: Catrope <[email protected]> Gerrit-Reviewer: Trevor Parscal <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
