Mooeypoo has uploaded a new change for review.
https://gerrit.wikimedia.org/r/220530
Change subject: Reattach VE toolbar so it is before VE debug bar
......................................................................
Reattach VE toolbar so it is before VE debug bar
The debug bar is attached as 'insertAfter' the target, but that
happens after the toolbar is already attached. This makes the debug
bar appear before the toolbar, which results in the debug bar being
unreachable, and also the toolbar appearing way under the surface.
We want to reattach the toolbar after the initialization is done
so it is back being right under the surface.
Bug: T103712
Change-Id: I0a36126eafe35575d228b4011524b06789716ff5
---
M modules/editor/editors/visualeditor/ext.flow.editors.visualeditor.js
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow
refs/changes/30/220530/1
diff --git
a/modules/editor/editors/visualeditor/ext.flow.editors.visualeditor.js
b/modules/editor/editors/visualeditor/ext.flow.editors.visualeditor.js
index e839608..4b9e723 100644
--- a/modules/editor/editors/visualeditor/ext.flow.editors.visualeditor.js
+++ b/modules/editor/editors/visualeditor/ext.flow.editors.visualeditor.js
@@ -65,6 +65,8 @@
surface = this.target.addSurface( this.dmDoc );
this.target.setSurface( surface );
this.target.$element.insertAfter( this.$node );
+ // Reattach the toolbar so it is before VE's debug bar
+ this.target.attachToolbar();
this.$node
.hide()
--
To view, visit https://gerrit.wikimedia.org/r/220530
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a36126eafe35575d228b4011524b06789716ff5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo <mor...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
