Polybuildr has uploaded a new change for review.
https://gerrit.wikimedia.org/r/220725
Change subject: Vector.php: Don't die on missing wfLoadSkin if in CLI
environment
......................................................................
Vector.php: Don't die on missing wfLoadSkin if in CLI environment
If wfLoadSkin does not exist, Vector.php dies. However, when running
`composer test`, Vector.php is included and wfLoadSkin does not exist,
hence it die()s. This patch changes the die to only echo the warning
if in CLI environment.
Bug: T103800
Change-Id: Icd8acc34f52be9c3c0f564744d2eb2aae7f34398
---
M Vector.php
1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Vector
refs/changes/25/220725/1
diff --git a/Vector.php b/Vector.php
index 1a06ea9..e6e38cd 100644
--- a/Vector.php
+++ b/Vector.php
@@ -10,5 +10,10 @@
); */
return true;
} else {
- die( 'This version of the Vector skin requires MediaWiki 1.25+' );
+ if ( PHP_SAPI !== 'cli' ) {
+ die( 'This version of the Vector skin requires MediaWiki 1.25+'
);
+ }
+ else {
+ echo "This version of the Vector skin requires MediaWiki
1.25+\n";
+ }
}
--
To view, visit https://gerrit.wikimedia.org/r/220725
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icd8acc34f52be9c3c0f564744d2eb2aae7f34398
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Vector
Gerrit-Branch: master
Gerrit-Owner: Polybuildr <v.a.ghai...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
