jenkins-bot has submitted this change and it was merged. Change subject: Don't output an empty h1 element (once more, with feeling) ......................................................................
Don't output an empty h1 element (once more, with feeling) Bug: T103077 Change-Id: I1a6944bb3da465a1cdcd1ce12aecfd19f4865ec9 --- M MonoBookTemplate.php 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Legoktm: Looks good to me, approved Polybuildr: Looks good to me, but someone else must approve Jforrester: Looks good to me, but someone else must approve Florianschmidtwelzow: Looks good to me, but someone else must approve jenkins-bot: Verified diff --git a/MonoBookTemplate.php b/MonoBookTemplate.php index 259b9ef..71170d5 100644 --- a/MonoBookTemplate.php +++ b/MonoBookTemplate.php @@ -57,7 +57,8 @@ <?php echo $this->getIndicators(); - if ( isset( $this->data['title'] ) ) { + // Loose comparison with '!=' is intentional, to catch null and false too, but not '0' + if ( $this->data['title'] != '' ) { ?> <h1 id="firstHeading" class="firstHeading" lang="<?php $this->data['pageLanguage'] = -- To view, visit https://gerrit.wikimedia.org/r/220745 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a6944bb3da465a1cdcd1ce12aecfd19f4865ec9 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/skins/MonoBook Gerrit-Branch: master Gerrit-Owner: Bartosz DziewoĆski <matma....@gmail.com> Gerrit-Reviewer: Florianschmidtwelzow <florian.schmidt.wel...@t-online.de> Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org> Gerrit-Reviewer: Legoktm <legoktm.wikipe...@gmail.com> Gerrit-Reviewer: Polybuildr <v.a.ghai...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits