jenkins-bot has submitted this change and it was merged.
Change subject: Fixed bug that appears, if identifier properties have
novalue-snaks.
......................................................................
Fixed bug that appears, if identifier properties have novalue-snaks.
Change-Id: Ie1beb71ce21b387ff08faa6d24b2226e8d782bdb
---
M includes/CrossCheck/CrossChecker.php
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Jonaskeutel: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/CrossCheck/CrossChecker.php
b/includes/CrossCheck/CrossChecker.php
index 4daa541..e980db0 100755
--- a/includes/CrossCheck/CrossChecker.php
+++ b/includes/CrossCheck/CrossChecker.php
@@ -164,7 +164,13 @@
StatementList $statements,
PropertyId $identifierPropertyId,
array $dumpMetaInformationList ) {
+ $resultList = new CrossCheckResultList();
+
$externalIds = $this->getExternalIds( $entity,
$identifierPropertyId );
+ if( !$externalIds ) {
+ return $resultList;
+ }
+
$dumpIds = array_map(
function ( DumpMetaInformation $dumpMetaInformation ) {
return $dumpMetaInformation->getDumpId();
@@ -173,7 +179,6 @@
);
$externalData = $this->externalDataRepo->getExternalData(
$dumpIds, $externalIds, $statements->getPropertyIds() );
- $resultList = new CrossCheckResultList();
foreach ( $externalData as $dumpId => $externalDataPerDump ) {
$dumpMetaInformation = $dumpMetaInformationList[
$dumpId ];
--
To view, visit https://gerrit.wikimedia.org/r/220915
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie1beb71ce21b387ff08faa6d24b2226e8d782bdb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQualityExternalValidation
Gerrit-Branch: master
Gerrit-Owner: Soeren.oldag <soeren_ol...@freenet.de>
Gerrit-Reviewer: Jonaskeutel <jonas.keu...@student.hpi.de>
Gerrit-Reviewer: Soeren.oldag <soeren_ol...@freenet.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
