Alex Monk has uploaded a new change for review.
https://gerrit.wikimedia.org/r/221160
Change subject: UserrightsPage: Avoid passing null target
......................................................................
UserrightsPage: Avoid passing null target
Bug: T103945
Change-Id: I80598ce6d12a73a7a3c399fbacc2a253999177b2
---
M includes/specials/SpecialUserrights.php
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/60/221160/1
diff --git a/includes/specials/SpecialUserrights.php
b/includes/specials/SpecialUserrights.php
index ab53951..f9f931e 100644
--- a/includes/specials/SpecialUserrights.php
+++ b/includes/specials/SpecialUserrights.php
@@ -106,7 +106,7 @@
}
}
- if ( User::getCanonicalName( $this->mTarget ) ===
$user->getName() ) {
+ if ( $this->mTarget && User::getCanonicalName( $this->mTarget )
=== $user->getName() ) {
$this->isself = true;
}
@@ -145,6 +145,7 @@
if (
$request->wasPosted() &&
$request->getCheck( 'saveusergroups' ) &&
+ $this->mTarget &&
$user->matchEditToken( $request->getVal( 'wpEditToken'
), $this->mTarget )
) {
// save settings
--
To view, visit https://gerrit.wikimedia.org/r/221160
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I80598ce6d12a73a7a3c399fbacc2a253999177b2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <kren...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
