Anomie has uploaded a new change for review. Change subject: (bug 42639) Fix API action=options for multiselect prefs ......................................................................
(bug 42639) Fix API action=options for multiselect prefs Preferences options using HTMLForm's "multiselect" type are stored in the user preferences table as one key with a boolean value for each option in the multiselect. The validation code added in change I98df55f2 does not take this into account, and therefore considers all of these option keys invalid. This changeset fixes that, and adds a unit test to verify correct behavior. Change-Id: I137c74a6045c7b39e2119a8edde2705738879bc9 --- M includes/api/ApiOptions.php M tests/phpunit/includes/api/ApiOptionsTest.php 2 files changed, 75 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/94/36494/1 -- To view, visit https://gerrit.wikimedia.org/r/36494 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I137c74a6045c7b39e2119a8edde2705738879bc9 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Anomie <bjor...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
