Filippo Giunchedi has uploaded a new change for review.
https://gerrit.wikimedia.org/r/221815
Change subject: restbase: drop illegal characters from alarm description
......................................................................
restbase: drop illegal characters from alarm description
apparently this is the default:
illegal_object_name_chars=`~!$%^&*"|'<>?,()=
See also T101799
Bug: T101764
Change-Id: Iaf4a32a82dd9f8fd5eed759123c95bd9c940d6f4
---
M manifests/role/restbase.pp
1 file changed, 10 insertions(+), 10 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/15/221815/1
diff --git a/manifests/role/restbase.pp b/manifests/role/restbase.pp
index ac3c598..60919bd 100644
--- a/manifests/role/restbase.pp
+++ b/manifests/role/restbase.pp
@@ -22,7 +22,7 @@
class role::restbase::alerts {
monitoring::graphite_threshold { 'restbase_request_5xx_rate':
- description => 'RESTBase req/s returning 5xx
(http://grafana.wikimedia.org/#/dashboard/db/restbase)',
+ description => 'RESTBase req/s returning 5xx
http://grafana.wikimedia.org/#/dashboard/db/restbase',
metric =>
'transformNull(restbase.v1_page_html_-title-_-revision--_tid-.GET.5xx.sample_rate,
0)',
from => '10min',
warning => '1', # 1 5xx/s
@@ -32,7 +32,7 @@
}
monitoring::graphite_threshold { 'restbase_html_storage_hit_latency':
- description => 'RESTBase HTML storage load mean latency ms
(http://grafana.wikimedia.org/#/dashboard/db/restbase)',
+ description => 'RESTBase HTML storage load mean latency ms
http://grafana.wikimedia.org/#/dashboard/db/restbase',
metric =>
'movingMedian(restbase.sys_key-rev-value_-bucket-_-key--_revision--_tid-.GET.2xx.mean,
15)',
from => '10min',
warning => '25', # 25ms
@@ -42,7 +42,7 @@
}
monitoring::graphite_threshold { 'restbase_html_storage_hit_latency_99p':
- description => 'RESTBase HTML storage load 99p latency ms
(http://grafana.wikimedia.org/#/dashboard/db/restbase)',
+ description => 'RESTBase HTML storage load 99p latency ms
http://grafana.wikimedia.org/#/dashboard/db/restbase',
metric =>
'movingMedian(restbase.sys_key-rev-value_-bucket-_-key--_revision--_tid-.GET.2xx.p99,
15)',
from => '10min',
warning => '1500', # 1.5s
@@ -52,7 +52,7 @@
}
monitoring::graphite_threshold {
'restbase_cassandra_highest_storage_exceptions':
- description => 'RESTBase Cassandra highest storage exceptions
(http://grafana.wikimedia.org/#/dashboard/db/restbase-cassandra-storage)',
+ description => 'RESTBase Cassandra highest storage exceptions
http://grafana.wikimedia.org/#/dashboard/db/restbase-cassandra-storage',
metric =>
'highestMax(nonNegativeDerivative(cassandra.restbase10*.org.apache.cassandra.metrics.Storage.Exceptions.count),
1)',
from => '10min',
warning => '5',
@@ -62,7 +62,7 @@
}
monitoring::graphite_threshold { 'restbase_cassandra_highest_total_hints':
- description => 'RESTBase Cassandra highest total hints
(http://grafana.wikimedia.org/#/dashboard/db/restbase-cassandra-storage)',
+ description => 'RESTBase Cassandra highest total hints
http://grafana.wikimedia.org/#/dashboard/db/restbase-cassandra-storage',
metric =>
'highestMax(nonNegativeDerivative(cassandra.restbase10*.org.apache.cassandra.metrics.Storage.TotalHints.count),
1)',
from => '10min',
warning => '600',
@@ -72,7 +72,7 @@
}
monitoring::graphite_threshold {
'restbase_cassandra_highest_pending_compactions':
- description => 'RESTBase Cassandra highest pending compactions
(http://grafana.wikimedia.org/#/dashboard/db/restbase-cassandra-compaction)',
+ description => 'RESTBase Cassandra highest pending compactions
http://grafana.wikimedia.org/#/dashboard/db/restbase-cassandra-compaction',
metric =>
'highestMax(cassandra.restbase10*.org.apache.cassandra.metrics.Compaction.PendingTasks.value,
1)',
from => '10min',
warning => '100',
@@ -82,7 +82,7 @@
}
monitoring::graphite_threshold {
'restbase_cassandra_highest_sstables_per_read':
- description => 'RESTBase Cassandra highest SSTables per-read
(http://grafana.wikimedia.org/#/dashboard/db/restbase-cassandra-cf-sstables-per-read)',
+ description => 'RESTBase Cassandra highest SSTables per-read
http://grafana.wikimedia.org/#/dashboard/db/restbase-cassandra-cf-sstables-per-read',
metric =>
'highestMax(cassandra.restbase10*.org.apache.cassandra.metrics.ColumnFamily.all.SSTablesPerReadHistogram.99percentile,
1)',
from => '10min',
warning => '6',
@@ -92,7 +92,7 @@
}
monitoring::graphite_threshold {
'restbase_cassandra_highest_tombstones_scanned':
- description => 'RESTBase Cassandra highest tombstones scanned
(http://grafana.wikimedia.org/#/dashboard/db/restbase-cassandra-cf-tombstones-scanned)',
+ description => 'RESTBase Cassandra highest tombstones scanned
http://grafana.wikimedia.org/#/dashboard/db/restbase-cassandra-cf-tombstones-scanned',
metric =>
'highestMax(cassandra.restbase10*.org.apache.cassandra.metrics.ColumnFamily.all.TombstoneScannedHistogram.99percentile,
1)',
from => '10min',
warning => '1000',
@@ -102,7 +102,7 @@
}
monitoring::graphite_threshold {
'restbase_cassandra_highest_pending_internal':
- description => 'RESTBase Cassandra highest pending internal thread
pool tasks
(http://grafana.wikimedia.org/#/dashboard/db/restbase-cassandra-thread-pools)',
+ description => 'RESTBase Cassandra highest pending internal thread
pool tasks
http://grafana.wikimedia.org/#/dashboard/db/restbase-cassandra-thread-pools',
metric =>
'highestMax(cassandra.restbase10*.org.apache.cassandra.metrics.ThreadPools.internal.*.PendingTasks.value,
1)',
from => '10min',
warning => '500',
@@ -112,7 +112,7 @@
}
monitoring::graphite_threshold {
'restbase_cassandra_highest_dropped_messages':
- description => 'RESTBase Cassandra highest dropped message rate
(http://grafana.wikimedia.org/#/dashboard/db/restbase-cassandra-dropped-messages)',
+ description => 'RESTBase Cassandra highest dropped message rate
http://grafana.wikimedia.org/#/dashboard/db/restbase-cassandra-dropped-messages',
metric =>
'highestMax(cassandra.restbase10*.org.apache.cassandra.metrics.DroppedMessage.*.Dropped.1MinuteRate,
1)',
from => '10min',
warning => '50',
--
To view, visit https://gerrit.wikimedia.org/r/221815
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaf4a32a82dd9f8fd5eed759123c95bd9c940d6f4
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Filippo Giunchedi <fgiunch...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
