Bgerstle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/221850
Change subject: history list performance tests
......................................................................
history list performance tests
Change-Id: I20ec399ec283240bd8d5dd56f8fac0755d4719a2
---
A MediaWikiKit/MediaWikiKitTests/MWKHistoryListPerformanceTests.m
M Wikipedia.xcodeproj/project.pbxproj
M Wikipedia.xcodeproj/xcshareddata/xcschemes/Wikipedia.xcscheme
3 files changed, 49 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/ios/wikipedia
refs/changes/50/221850/1
diff --git a/MediaWikiKit/MediaWikiKitTests/MWKHistoryListPerformanceTests.m
b/MediaWikiKit/MediaWikiKitTests/MWKHistoryListPerformanceTests.m
new file mode 100644
index 0000000..72b458d
--- /dev/null
+++ b/MediaWikiKit/MediaWikiKitTests/MWKHistoryListPerformanceTests.m
@@ -0,0 +1,41 @@
+//
+// MWKHistoryListPerformanceTests.m
+// Wikipedia
+//
+// Created by Brian Gerstle on 6/29/15.
+// Copyright (c) 2015 Wikimedia Foundation. All rights reserved.
+//
+
+#import <UIKit/UIKit.h>
+#import <XCTest/XCTest.h>
+
+#import "NSDateFormatter+WMFExtensions.h"
+#import "WMFTestFixtureUtilities.h"
+#import "MWKHistoryList.h"
+
+@interface MWKHistoryListPerformanceTests : XCTestCase
+
+@end
+
+@implementation MWKHistoryListPerformanceTests
+
+- (void)testReadPerformance {
+ NSMutableArray* entries = [NSMutableArray arrayWithCapacity:1000];
+ for (int i = 0; i < 1000; i++) {
+ [entries addObject:@{
+ @"language": @"en",
+ @"domain": @"wikipedia.org",
+ @"title": [[NSUUID UUID] UUIDString],
+ @"date": [[NSDateFormatter wmf_iso8601Formatter]
stringFromDate:[NSDate date]],
+ @"scrollPosition": @0,
+ @"discoveryMethod": [MWKHistoryEntry
stringForDiscoveryMethod:MWKHistoryDiscoveryMethodLink]
+ }];
+ }
+
+ [self measureBlock:^{
+ MWKHistoryList* list = [[MWKHistoryList alloc]
initWithDict:NSDictionaryOfVariableBindings(entries)];
+ XCTAssertEqual(list.length, [entries count]);
+ }];
+}
+
+@end
diff --git a/Wikipedia.xcodeproj/project.pbxproj
b/Wikipedia.xcodeproj/project.pbxproj
index 5e52831..777b9af 100644
--- a/Wikipedia.xcodeproj/project.pbxproj
+++ b/Wikipedia.xcodeproj/project.pbxproj
@@ -332,6 +332,7 @@
BCF012331AD2FA38008D3675 /* assets in Resources */ = {isa =
PBXBuildFile; fileRef = BCF012321AD2FA38008D3675 /* assets */; };
BCFE026A1B41ABB5003752B7 /* MWKHistoryListCorruptDataTests.m in
Sources */ = {isa = PBXBuildFile; fileRef = BCFE02691B41ABB5003752B7 /*
MWKHistoryListCorruptDataTests.m */; };
BCFE026F1B41B482003752B7 /* MWKSavedPageListCorruptDataTests.m
in Sources */ = {isa = PBXBuildFile; fileRef = BCFE026E1B41B482003752B7 /*
MWKSavedPageListCorruptDataTests.m */; };
+ BCFE02781B41FA12003752B7 /* MWKHistoryListPerformanceTests.m in
Sources */ = {isa = PBXBuildFile; fileRef = BCFE02771B41FA12003752B7 /*
MWKHistoryListPerformanceTests.m */; };
C42D947E1A937DAC00A4871A /* SavedArticlesFetcher.m in Sources
*/ = {isa = PBXBuildFile; fileRef = C42D947D1A937DAC00A4871A /*
SavedArticlesFetcher.m */; };
C42D94861A937DE000A4871A /* WMFBorderButton.m in Sources */ =
{isa = PBXBuildFile; fileRef = C42D94831A937DE000A4871A /* WMFBorderButton.m
*/; };
C42D94871A937DE000A4871A /* WMFProgressLineView.m in Sources */
= {isa = PBXBuildFile; fileRef = C42D94851A937DE000A4871A /*
WMFProgressLineView.m */; };
@@ -979,6 +980,7 @@
BCF012321AD2FA38008D3675 /* assets */ = {isa =
PBXFileReference; lastKnownFileType = folder; name = assets; path =
../Wikipedia/assets; sourceTree = "<group>"; };
BCFE02691B41ABB5003752B7 /* MWKHistoryListCorruptDataTests.m */
= {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType =
sourcecode.c.objc; path = MWKHistoryListCorruptDataTests.m; sourceTree =
"<group>"; };
BCFE026E1B41B482003752B7 /* MWKSavedPageListCorruptDataTests.m
*/ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType =
sourcecode.c.objc; path = MWKSavedPageListCorruptDataTests.m; sourceTree =
"<group>"; };
+ BCFE02771B41FA12003752B7 /* MWKHistoryListPerformanceTests.m */
= {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType =
sourcecode.c.objc; path = MWKHistoryListPerformanceTests.m; sourceTree =
"<group>"; };
C42D947C1A937DAC00A4871A /* SavedArticlesFetcher.h */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path =
SavedArticlesFetcher.h; sourceTree = "<group>"; };
C42D947D1A937DAC00A4871A /* SavedArticlesFetcher.m */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path
= SavedArticlesFetcher.m; sourceTree = "<group>"; };
C42D94821A937DE000A4871A /* WMFBorderButton.h */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path =
WMFBorderButton.h; sourceTree = "<group>"; };
@@ -2310,6 +2312,7 @@
BCB58F7D1A8D1B8400465627 /*
MWKImageInfo+MWKImageComparisonTests.m */,
BCFE02691B41ABB5003752B7 /*
MWKHistoryListCorruptDataTests.m */,
BCFE026E1B41B482003752B7 /*
MWKSavedPageListCorruptDataTests.m */,
+ BCFE02771B41FA12003752B7 /*
MWKHistoryListPerformanceTests.m */,
);
name = MediaWikiKitTests;
path = ../MediaWikiKit/MediaWikiKitTests;
@@ -2971,6 +2974,7 @@
files = (
BC6BF4001B19213600362968 /*
XCTestCase+WMFLocaleTesting.m in Sources */,
0EBC56971AD5B69300E82CDD /*
BITHockeyManager+WMFExtensions.m in Sources */,
+ BCFE02781B41FA12003752B7 /*
MWKHistoryListPerformanceTests.m in Sources */,
BC2375C11ABB14CC00B0BAA8 /*
WMFArticleImageInjectionTests.m in Sources */,
043B6E8F1ACDE0CF0005C60B /*
NSAttributedString+WMFSavedPagesAttributedStrings.m in Sources */,
BCDB75C41AB0E8300005593F /*
WMFSubstringUtilsTests.m in Sources */,
diff --git a/Wikipedia.xcodeproj/xcshareddata/xcschemes/Wikipedia.xcscheme
b/Wikipedia.xcodeproj/xcshareddata/xcschemes/Wikipedia.xcscheme
index 817c319..28afa72 100644
--- a/Wikipedia.xcodeproj/xcshareddata/xcschemes/Wikipedia.xcscheme
+++ b/Wikipedia.xcodeproj/xcshareddata/xcschemes/Wikipedia.xcscheme
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "0620"
- version = "1.3">
+ version = "1.7">
<BuildAction
parallelizeBuildables = "YES"
buildImplicitDependencies = "YES">
@@ -84,6 +84,9 @@
</BuildableProductRunnable>
<AdditionalOptions>
</AdditionalOptions>
+ <DeviceAppData
+ resolvedPath = "../4.0.6 extreme memory test data.xcappdata">
+ </DeviceAppData>
</LaunchAction>
<ProfileAction
shouldUseLaunchSchemeArgsEnv = "YES"
--
To view, visit https://gerrit.wikimedia.org/r/221850
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I20ec399ec283240bd8d5dd56f8fac0755d4719a2
Gerrit-PatchSet: 1
Gerrit-Project: apps/ios/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Bgerstle <bgers...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
