jenkins-bot has submitted this change and it was merged.
Change subject: fix minor bug in range checker
......................................................................
fix minor bug in range checker
parameter min and max now get passed to checkResult
Change-Id: Iac02d117c44247f7172c219018cf39807c3ee662
---
M includes/ConstraintCheck/Checker/RangeChecker.php
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Soeren.oldag: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/ConstraintCheck/Checker/RangeChecker.php
b/includes/ConstraintCheck/Checker/RangeChecker.php
index a2bc7e5..1d4d9e1 100755
--- a/includes/ConstraintCheck/Checker/RangeChecker.php
+++ b/includes/ConstraintCheck/Checker/RangeChecker.php
@@ -77,8 +77,8 @@
if ( array_key_exists( 'minimum_quantity',
$constraintParameters ) && array_key_exists( 'maximum_quantity',
$constraintParameters ) && !array_key_exists( 'minimum_date',
$constraintParameters ) && !array_key_exists( 'maximum_date',
$constraintParameters ) ) {
$min =
$constraintParameters['minimum_quantity'];
$max =
$constraintParameters['maximum_quantity'];
- $parameters['minimum_quantity'] =
$this->constraintParameterParser->parseSingleParameter(
$constraintParameters['minimum_quantity'] );
- $parameters['maximum_quantity'] =
$this->constraintParameterParser->parseSingleParameter(
$constraintParameters['maximum_quantity'] );
+ $parameters['minimum_quantity'] =
$this->constraintParameterParser->parseSingleParameter(
$constraintParameters['minimum_quantity'], true );
+ $parameters['maximum_quantity'] =
$this->constraintParameterParser->parseSingleParameter(
$constraintParameters['maximum_quantity'], true );
} else {
$message = wfMessage(
"wbqc-violation-message-range-parameters-needed" )->params( 'quantity',
'minimum_quantity" and "maximum_quantity' )->escaped();
}
@@ -86,8 +86,8 @@
if ( !array_key_exists( 'minimum_quantity',
$constraintParameters ) && !array_key_exists( 'maximum_quantity',
$constraintParameters ) && array_key_exists( 'minimum_date',
$constraintParameters ) && array_key_exists( 'maximum_date',
$constraintParameters ) ) {
$min = $constraintParameters['minimum_date'];
$max = $constraintParameters['maximum_date'];
- $parameters['minimum_date'] =
$this->constraintParameterParser->parseSingleParameter(
$constraintParameters['minimum_date'] );
- $parameters['maximum_date'] =
$this->constraintParameterParser->parseSingleParameter(
$constraintParameters['maximum_date'] );
+ $parameters['minimum_date'] =
$this->constraintParameterParser->parseSingleParameter(
$constraintParameters['minimum_date'], true );
+ $parameters['maximum_date'] =
$this->constraintParameterParser->parseSingleParameter(
$constraintParameters['maximum_date'], true );
} else {
$message = wfMessage(
"wbqc-violation-message-range-parameters-needed" )->params( 'time',
'minimum_date" and "maximum_date' )->escaped();
}
--
To view, visit https://gerrit.wikimedia.org/r/222072
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iac02d117c44247f7172c219018cf39807c3ee662
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQualityConstraints
Gerrit-Branch: v1
Gerrit-Owner: Jonaskeutel <jonas.keu...@student.hpi.de>
Gerrit-Reviewer: Soeren.oldag <soeren_ol...@freenet.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
