Giuseppe Lavagetto has submitted this change and it was merged.
Change subject: etcd::ssl: do not restart the server upon changes
......................................................................
etcd::ssl: do not restart the server upon changes
Restarts of etcd should be limited to cases where we change disruptively
the configuration - a change of the underlying certificates isn't (etcd
will still serve the same data from the same cluster) and automatic
restarts are scary to say the least.
Disable them from now on, until we use intra-cluster SSL certificates.
Change-Id: Ib1a9cc9efe81ff7a8da66adfa5f5c4075226cf11
---
M modules/etcd/manifests/ssl.pp
1 file changed, 0 insertions(+), 3 deletions(-)
Approvals:
Giuseppe Lavagetto: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/etcd/manifests/ssl.pp b/modules/etcd/manifests/ssl.pp
index c13f8cc..c034ee9 100644
--- a/modules/etcd/manifests/ssl.pp
+++ b/modules/etcd/manifests/ssl.pp
@@ -34,7 +34,6 @@
group => 'etcd',
mode => '0400',
source => "${ssldir}/certs/ca.pem",
- notify => Service['etcd'],
}
file { '/var/lib/etcd/ssl/certs/cert.pem':
@@ -44,7 +43,6 @@
mode => '0400',
source => "${ssldir}/certs/${puppet_cert_name}.pem",
require => File['/var/lib/etcd/ssl/certs/ca.pem'],
- notify => Service['etcd'],
}
file { '/var/lib/etcd/ssl/private_keys':
@@ -60,6 +58,5 @@
group => 'etcd',
mode => '0400',
source => "${ssldir}/private_keys/${puppet_cert_name}.pem",
- notify => Service['etcd'],
}
}
--
To view, visit https://gerrit.wikimedia.org/r/222102
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib1a9cc9efe81ff7a8da66adfa5f5c4075226cf11
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Giuseppe Lavagetto <glavage...@wikimedia.org>
Gerrit-Reviewer: Giuseppe Lavagetto <glavage...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
