Filippo Giunchedi has submitted this change and it was merged.
Change subject: increase size of key cache to 400MB
......................................................................
increase size of key cache to 400MB
The key cache hit rate at 100MB is:
* 0.342 restbase1001
* 0.344 restbase1002
* 0.404 restbase1003
* 0.261 restbase1004
* 0.226 restbase1005
* 0.364 restbase1006
Thus, the additional 300MB should be well spent in savings on index reads.
Change-Id: I8d15c8618d83a94f5defd31f0639f61de54a717f
---
M modules/cassandra/manifests/init.pp
M modules/cassandra/templates/cassandra.yaml.erb
2 files changed, 5 insertions(+), 1 deletion(-)
Approvals:
Filippo Giunchedi: Verified; Looks good to me, approved
Mobrovac: Looks good to me, but someone else must approve
diff --git a/modules/cassandra/manifests/init.pp
b/modules/cassandra/manifests/init.pp
index 6758339..f87d7bb 100644
--- a/modules/cassandra/manifests/init.pp
+++ b/modules/cassandra/manifests/init.pp
@@ -172,6 +172,9 @@
# if $endpoint_snitch is GossipingPropertyFileSnitch.
# Default rack1
#
+# [*key_cache_size_in_mb*]
+# Maximum size of the key cache in memory.
+# Default: empty (aka "auto" (min(5% of heap (in MB), 100MB)))
class cassandra(
$cluster_name = 'Test Cluster',
$seeds = [$::ipaddress],
@@ -210,6 +213,7 @@
$extra_classpath = [],
$dc = 'datacenter1',
$rack = 'rack1',
+ $key_cache_size_in_mb = 400,
$yaml_template = "${module}/cassandra.yaml.erb",
$env_template = "${module}/cassandra-env.sh.erb",
diff --git a/modules/cassandra/templates/cassandra.yaml.erb
b/modules/cassandra/templates/cassandra.yaml.erb
index 994bd53..dc23590 100644
--- a/modules/cassandra/templates/cassandra.yaml.erb
+++ b/modules/cassandra/templates/cassandra.yaml.erb
@@ -141,7 +141,7 @@
# NOTE: if you reduce the size, you may not get you hottest keys loaded on
startup.
#
# Default value is empty to make it "auto" (min(5% of Heap (in MB), 100MB)).
Set to 0 to disable key cache.
-key_cache_size_in_mb:
+key_cache_size_in_mb: <%= @key_cache_size_in_mb %>
# Duration in seconds after which Cassandra should
# save the key cache. Caches are saved to saved_caches_directory as
--
To view, visit https://gerrit.wikimedia.org/r/222189
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8d15c8618d83a94f5defd31f0639f61de54a717f
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Eevans <eev...@wikimedia.org>
Gerrit-Reviewer: Filippo Giunchedi <fgiunch...@wikimedia.org>
Gerrit-Reviewer: GWicke <gwi...@wikimedia.org>
Gerrit-Reviewer: Mobrovac <mobro...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
