jenkins-bot has submitted this change and it was merged. Change subject: WikidataPageBanner remove url for 2x from srcset ......................................................................
WikidataPageBanner remove url for 2x from srcset Remove the image-url for 2x from srcset. 'w' takes care of hi-res devices. See http://stackoverflow.com/questions/26928828/html5-srcset-mixing-x-and-w-syntax. Bug: T103994 Change-Id: I46180fbd8eaaf4f3bb7f3c505bcf9902f8d45249 --- M includes/WikidataPageBanner.hooks.php 1 file changed, 4 insertions(+), 6 deletions(-) Approvals: Jdlrobson: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/WikidataPageBanner.hooks.php b/includes/WikidataPageBanner.hooks.php index bcff517..804a4cf 100644 --- a/includes/WikidataPageBanner.hooks.php +++ b/includes/WikidataPageBanner.hooks.php @@ -174,7 +174,7 @@ $urls = static::getStandardSizeUrls( $bannername ); $banner = null; /** @var String srcset attribute for <img> element of banner image */ - $srcset = ""; + $srcset = array(); // if a valid bannername given, set banner if ( !empty( $urls ) ) { // @var int index variable @@ -183,14 +183,12 @@ $size = $wgStandardSizes[$i]; // add url with width and a comma if not adding the last url if ( $i < count( $urls ) ) { - $srcset .= "$url {$size}w,"; + $srcset[] = "$url {$size}w"; } $i++; } - // only use the largest size url as a hi-res banner url, as a mix - // of 'w' and 'x' causes issues in chrome - $url = $urls[$i-1]; - $srcset .= "$url 2x"; + // create full src set from individual urls, separated by comma + $srcset = implode( ',', $srcset ); $bannerurl = $urls[0]; $bannerfile = str_replace( "$1", "File:$bannername", $wgArticlePath ); $templateParser = new TemplateParser( __DIR__ . '/../templates' ); -- To view, visit https://gerrit.wikimedia.org/r/221898 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I46180fbd8eaaf4f3bb7f3c505bcf9902f8d45249 Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/WikidataPageBanner Gerrit-Branch: master Gerrit-Owner: Sumit <asthana.sumi...@gmail.com> Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
