Jdlrobson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/222498

Change subject: Disable search overlay on Blackberry 9930
......................................................................

Disable search overlay on Blackberry 9930

Bug: T102553
Change-Id: I8cf22e60acb5d7ff15f9fef13a05859394600e8f
---
M resources/mobile.search/init.js
A resources/skins.minerva.tablet.beta.styles/mainmenu.less
2 files changed, 33 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/98/222498/1

diff --git a/resources/mobile.search/init.js b/resources/mobile.search/init.js
index 66cb024..000b106 100644
--- a/resources/mobile.search/init.js
+++ b/resources/mobile.search/init.js
@@ -47,7 +47,8 @@
        }
 
        // See https://phabricator.wikimedia.org/T76882 for why we disable 
search on Android 2
-       if ( browser.isAndroid2() ) {
+       // See https://phabricator.wikimedia.org/T102553 for why we disable 
this on Blackberry
+       if ( browser.isAndroid2() || /BlackBerry 9930/.test( browser.userAgent 
) ) {
                $( 'body' ).addClass( 'client-use-basic-search' );
        } else {
                // don't use focus event 
(https://bugzilla.wikimedia.org/show_bug.cgi?id=47499)
diff --git a/resources/skins.minerva.tablet.beta.styles/mainmenu.less 
b/resources/skins.minerva.tablet.beta.styles/mainmenu.less
new file mode 100644
index 0000000..ebb75a5
--- /dev/null
+++ b/resources/skins.minerva.tablet.beta.styles/mainmenu.less
@@ -0,0 +1,31 @@
+@import "minerva.variables";
+@import "minerva.mixins";
+
+@menuBorder: 12px;
+
+//1379 = 768px * 2
+// FIXME: Move to mobile.mainMenu/mainMenu.less when pushing to stable
+@media all and (min-width: @wgMFDeviceWidthTablet) {
+       @menuFullWidth: @menuWidth + @menuBorder;
+       .primary-navigation-enabled.animations {
+               .position-fixed
+               #mw-mf-page-center {
+                       position: relative;
+
+                       > * {
+                               .transform(translate(-@menuFullWidth, 0)) 
!important;
+                       }
+
+               }
+
+               // do this better
+               #content_wrapper {
+                       border-top: none;
+               }
+
+               .header {
+                       position: relative;
+                       left: (-@menuFullWidth)/2;
+               }
+       } 
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/222498
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8cf22e60acb5d7ff15f9fef13a05859394600e8f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to